From 868d361224f3c9915b694c974b4bafb9815e676c Mon Sep 17 00:00:00 2001 From: Lucas Gass Date: Wed, 25 Jun 2025 16:20:24 +0000 Subject: [PATCH] Bug 35947: Show account manager info regardless of HidePatronName pref 1) Set 'HidePatronName' sys. pref. to 'Don't show' 2) Go to a patron's page 3) Click on the accounting tab 4) Select 'Create manual invoice', put in an amount and press save. 5) In the transactions tab, click on the details of that specifc transaction 6) Note that in the "Details of debit" table, the Librarian is set to 'a patron from X branch' 7) Apply patch, restart_all 8) Go to the same transaction, notice that now it says the actual librarian who was in charge of creating transaction. 9) Click on this name and make sure the link works 10) Go back to accounting section and now make a payment. 11) View details of this transaction and ensure the librarian is present --- .../en/modules/members/accountline-details.tt | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt index 44e3adeb001..528c149113f 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt @@ -134,7 +134,14 @@ [% accountline.amountoutstanding | $Price %] [% IF accountline.manager_id %] - [% INCLUDE 'patron-title.inc' patron => accountline.manager, hide_patron_infos_if_needed => 1, no_cardnumber => 1 %] + + [% IF ( accountline.manager.firstname || accountline.manager.surname ) %] + [% accountline.manager.firstname | uri %] + [% accountline.manager.surname | uri %] + [% ELSE %] + [% accountline.manager.borrowernumber | uri %] + [% END %] + [% END %] @@ -198,7 +205,14 @@ [% offset_accountline.amount | $Price %] [% IF offset_accountline.manager_id %] - [% INCLUDE 'patron-title.inc' patron => offset_accountline.manager, hide_patron_infos_if_needed => 1, no_cardnumber => 1 %] + + [% IF ( offset_accountline.manager.firstname || offset_accountline.manager.surname ) %] + [% offset_accountline.manager.firstname | uri %] + [% offset_accountline.manager.surname | uri %] + [% ELSE %] + [% offset_accountline.manager.borrowernumber | uri %] + [% END %] + [% END %] [%- ELSE -%] -- 2.39.5