From ff7e38dbf30ff43c7ef6e64d52e7d261a936f81d Mon Sep 17 00:00:00 2001 From: Fridolin Somers Date: Mon, 30 Jun 2025 17:04:12 +0200 Subject: [PATCH] Bug 40277: Remove warn in C4::Koha::GetAuthorisedValues() When using the OPAC and you are not logged in, there are warnings in the logs: [WARN] Use of uninitialized value $branch_limit in concatenation (.) or string It comes from C4::Koha::GetAuthorisedValues() : my $branch_limit = C4::Context->userenv ? C4::Context->userenv->{"branch"} : ""; my $cache_key = "AuthorisedValues-$category-$opac-$branch_limit"; C4::Context->userenv->{"branch"} can be undef The patch fixes using C4::Context::mybranch(). Test plan: 1. Set the OpacAdvancedSearchTypes system preference to something other than "itemtypes", for example "loc". 2. Go to OPAC without logging in, and perform a search. 3. Check the /var/log/koha/kohadev/plack-opac-error.log and note the warnings in the log: [WARN] Use of uninitialized value $branch_limit in concatenation (.) or ... (Alternative, tail the logs: tail -f /var/log/koha/kohadev/*.log 4. Apply the patch. 5. Repeat step 2 and check that there are no longer any warnings. 6. Sign off. Signed-off-by: David Nind --- C4/Koha.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Koha.pm b/C4/Koha.pm index 13e7a5da7d..bee096db9f 100644 --- a/C4/Koha.pm +++ b/C4/Koha.pm @@ -513,7 +513,7 @@ sub GetAuthorisedValues { my $opac = shift ? 1 : 0; # normalise to be safe # Is this cached already? - my $branch_limit = C4::Context->userenv ? C4::Context->userenv->{"branch"} : ""; + my $branch_limit = C4::Context::mybranch(); my $cache_key = "AuthorisedValues-$category-$opac-$branch_limit"; my $cache = Koha::Caches->get_instance(); my $result = $cache->get_from_cache($cache_key); -- 2.39.5