From abec7f282162ae646468377d3365a5629b6133d0 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Wed, 18 Jun 2025 16:59:08 +0000 Subject: [PATCH] Bug 40165: Incomplete logic for controlling display of OPAC language footer Content-Type: text/plain; charset=utf-8 This patch adds some additional logic to the template which controls the appearance of the footer in the OPAC. Some additional checks are required to make sure an empty footer doesn't display in some circumstances. To test, apply the patch and install at least one additional translation besides English. Check any OPAC page when various combinations of system preferences are enabled: - opaclanguagesdisplay - OPACLanguages - OpacLangSelectorMode - OPACReportProblem - CookieConsent - OpacKohaUurl In particular, confirm that there is not an empty footer when opaclanguagesdisplay is enabled but there is only one translation enabled. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny Signed-off-by: Marcel de Rooy --- koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc index 065c89c471..205f9b2375 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc @@ -22,7 +22,7 @@ - [% IF ( Koha.Preference('OPACReportProblem') && Koha.Preference('KohaAdminEmailAddress') ) || Koha.Preference( 'CookieConsent' ) || OpacKohaUrl || ( ( OpacLangSelectorMode == 'both' || OpacLangSelectorMode == 'footer') ) %] + [% IF ( Koha.Preference('OPACReportProblem') && Koha.Preference('KohaAdminEmailAddress') ) || Koha.Preference( 'CookieConsent' ) || OpacKohaUrl || ( ( opaclanguagesdisplay ) && ( ! one_language_enabled ) && ( languages_loop ) && ( OpacLangSelectorMode == 'both' || OpacLangSelectorMode == 'footer') ) %]