From 837d160b5fa57f63e4be7c5751687da59fcc1758 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 15 Jul 2025 11:20:32 +0200 Subject: [PATCH] Bug 40373: Remove warning from Reserves.t t/db_dependent/Reserves.t .. 10/70 No reserves HOLD_CANCELLATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 602. We do not test the notification here, we can simply ignore the letters code. However we do test it later so we need to limit the scope of mock --- t/db_dependent/Reserves.t | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t index a9224528157..cced1feee76 100755 --- a/t/db_dependent/Reserves.t +++ b/t/db_dependent/Reserves.t @@ -17,7 +17,8 @@ use Modern::Perl; -use Test::More tests => 70; +use Test::More tests => 71; +use Test::NoWarnings; use Test::MockModule; use Test::Warn; @@ -413,7 +414,14 @@ is( $which_highest->{reserve_id}, $reserve_id, 'CheckReserves returns higher priority future reserve with sufficient lookahead' ); -ModReserve( { reserve_id => $now_reserve_id, rank => 'del', cancellation_reason => 'test reserve' } ); + +{ + # Prevent warning 'No reserves HOLD_CANCELLATION letter transported by email' + my $mock_letters = Test::MockModule->new('C4::Letters'); + $mock_letters->mock( 'GetPreparedLetter', sub { return } ); + + ModReserve( { reserve_id => $now_reserve_id, rank => 'del', cancellation_reason => 'test reserve' } ); +} # End of tests for bug 9761 (ConfirmFutureHolds) -- 2.34.1