From 77e79584cc2c1c924290b01034cb18abfd1546d2 Mon Sep 17 00:00:00 2001 From: Aleisha Amohia Date: Wed, 5 Jun 2024 05:12:59 +0000 Subject: [PATCH] Bug 31606: Make acquisitions fund dropdown consistently show budget name This patch moves the budget/fund dropdown into a reusable block. So far it has only been applied to dropdowns encountered along the basic order & receive process. To test: 1) Apply patch and restart services 2) Create two budgets. Under each budget, create funds with the same codes (this is so we can depend on the budget names to differentiate between funds). Make one or more funds inactive. 3) Find or create a vendor and an open basket 4) Click Add to basket 5) Search for an existing record 6) Click Add order for your chosen record 7) Fill out required item information 8) Scroll down to Accounting details and open the Fund dropdown. Confirm funds show as expected with their budgets 9) Toggle the 'Show inactive' checkbox and confirm it shows and hides inactive funds as expected 10) Cancel or Save your order 11) In another tab, go to Suggestions 12) Click New purchase suggestion 13) Fill out required bibliographic information 14) Scroll down to Acquisition information and open the Fund dropdown. Confirm funds show as expected with their budgets 15) Toggle the 'Show inactive' checkbox and confirm it shows and hides inactive funds as expected 16) Submit your suggestion 17) Check the checkbox for your suggestion and mark it as Accepted 18) In your other tab with your basket, click Add to basket 19) Choose From a suggestion 20) Click Order for your suggestion 21) Fill out required item information 22) Scroll down to Accounting details and open the Fund dropdown. Confirm funds show as expected with their budgets 23) Toggle the 'Show inactive' checkbox and confirm it shows and hides inactive funds as expected 24) Cancel or Save your order 25) In another tab, go to Serials 26) Click New subscription 27) Fill out required record and serials planning information and Save 28) In your other tab with your basket, click Add to basket 29) Choose From a subscription 30) Search for your subscription and choose Order 31) Scroll down to Accounting details and open the Fund dropdown. Confirm funds show as expected with their budgets 32) Toggle the 'Show inactive' checkbox and confirm it shows and hides inactive funds as expected 33) Cancel or Save your order 34) Click Add to basket 35) Choose From existing orders (copy) 36) Open the Fund dropdown. Confirm funds show as expected with their budgets 37) Do a search and check the checkbox for an order, then click Next 38) Open the Fund dropdown. Confirm funds show as expected with their budgets 39) Toggle the 'Show inactive' checkbox and confirm it shows and hides inactive funds as expected 40) Cancel or Duplicate orders 41) Click Add to basket 42) Choose From a new file 43) Upload a MARC file and stage a record for import, then choose Add staged files to basket 44) Select a checkbox for a record to expand it 45) Open the Fund dropdown. Confirm funds show as expected with their budgets 46) Go to the Default accounting details tab 47) Open the Fund dropdown. Confirm funds show as expected with their budgets 48) Toggle the 'Show inactive' checkbox and confirm it shows and hides inactive funds as expected 49) Save your order 50) Close the basket 51) Click Receive shipments 52) Open the Shipping fund dropdown. Confirm funds show as expected with their budgets 53) Toggle the 'Show inactive' checkbox and confirm it shows and hides inactive funds as expected 54) Fill out required invoice information and Save 55) Click Receive for one of your orders 56) Open the Fund dropdown. Confirm funds show as expected with their budgets 57) Toggle the 'Show inactive' checkbox and confirm it shows and hides inactive funds as expected Sponsored-by: Friends of Round Rock Library Signed-off-by: Rhonda Kuiper --- acqui/addorderiso2709.pl | 18 +-- acqui/duplicate_orders.pl | 26 +++-- acqui/invoice.pl | 27 ++--- acqui/neworderempty.pl | 13 ++- acqui/orderreceive.pl | 2 +- acqui/parcels.pl | 27 +++-- .../prog/en/includes/budgets_loop.inc | 28 +++++ .../prog/en/modules/acqui/addorderiso2709.tt | 104 +++++++----------- .../prog/en/modules/acqui/duplicate_orders.tt | 12 +- .../prog/en/modules/acqui/invoice.tt | 10 +- .../prog/en/modules/acqui/neworderempty.tt | 29 +---- .../prog/en/modules/acqui/orderreceive.tt | 39 +------ .../prog/en/modules/acqui/parcels.tt | 8 +- .../prog/en/modules/suggestion/suggestion.tt | 12 +- suggestion/suggestion.pl | 31 ++++-- 15 files changed, 159 insertions(+), 227 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/budgets_loop.inc diff --git a/acqui/addorderiso2709.pl b/acqui/addorderiso2709.pl index a1533ec338f..7cfa45776ac 100755 --- a/acqui/addorderiso2709.pl +++ b/acqui/addorderiso2709.pl @@ -314,12 +314,16 @@ my $patron = Koha::Patrons->find($loggedinuser)->unblessed; my $budget = GetBudget($budget_id); # build budget list -my $budget_loop = []; +my %budget_loops; my $budgets_hierarchy = GetBudgetHierarchy; foreach my $r ( @{$budgets_hierarchy} ) { next unless ( CanUserUseBudget( $patron, $r, $userflags ) ); - push @{$budget_loop}, - { + unless ( defined $budget_loops{ $r->{budget_period_id} } ) { + $budget_loops{ $r->{budget_period_id} }->{description} = $r->{budget_period_description}; + $budget_loops{ $r->{budget_period_id} }->{active} = $r->{budget_period_active}; + $budget_loops{ $r->{budget_period_id} }->{funds} = []; + } + push @{ $budget_loops{ $r->{budget_period_id} }->{funds} }, { b_id => $r->{budget_id}, b_txt => $r->{budget_name}, b_code => $r->{budget_code}, @@ -327,12 +331,10 @@ foreach my $r ( @{$budgets_hierarchy} ) { b_sort2_authcat => $r->{'sort2_authcat'}, b_active => $r->{budget_period_active}, b_sel => ( $r->{budget_id} == $budget_id ) ? 1 : 0, - }; + b_level => $r->{budget_level}, + }; } -@{$budget_loop} = - sort { uc( $a->{b_txt} ) cmp uc( $b->{b_txt} ) } @{$budget_loop}; - -$template->param( budget_loop => $budget_loop, ); +$template->param( budget_loop => \%budget_loops ); output_html_with_http_headers $input, $cookie, $template->output; diff --git a/acqui/duplicate_orders.pl b/acqui/duplicate_orders.pl index 3b065153aac..acedccad3dd 100755 --- a/acqui/duplicate_orders.pl +++ b/acqui/duplicate_orders.pl @@ -102,28 +102,30 @@ if ( $op eq 'select' ) { @ordernumbers = $input->multi_param('ordernumber'); # build budget list - my $budget_loop = []; - my $budgets_hierarchy = GetBudgetHierarchy; - foreach my $r ( @{$budgets_hierarchy} ) { - next - unless ( C4::Budgets::CanUserUseBudget( $patron, $r, $userflags ) ); - - push @{$budget_loop}, - { + my %budget_loops; + my $budgets = GetBudgetHierarchy; + foreach my $r ( @{$budgets} ) { + next unless ( CanUserUseBudget( $patron, $r, $userflags ) ); + unless ( defined $budget_loops{ $r->{budget_period_id} } ) { + $budget_loops{ $r->{budget_period_id} }->{description} = $r->{budget_period_description}; + $budget_loops{ $r->{budget_period_id} }->{active} = $r->{budget_period_active}; + $budget_loops{ $r->{budget_period_id} }->{funds} = []; + } + push @{ $budget_loops{ $r->{budget_period_id} }->{funds} }, { b_id => $r->{budget_id}, b_txt => $r->{budget_name}, b_code => $r->{budget_code}, b_sort1_authcat => $r->{'sort1_authcat'}, b_sort2_authcat => $r->{'sort2_authcat'}, b_active => $r->{budget_period_active}, - }; + b_sel => ( $r->{budget_id} == scalar $input->param('budget') ) ? 1 : 0, + b_level => $r->{budget_level}, + }; } - @{$budget_loop} = - sort { uc( $a->{b_txt} ) cmp uc( $b->{b_txt} ) } @{$budget_loop}; $template->param( currencies => Koha::Acquisition::Currencies->search, - budget_loop => $budget_loop, + budget_loop => \%budget_loops, ); } elsif ( $op eq 'cud-do_duplicate' ) { my @fields_to_copy = $input->multi_param('copy_existing_value'); diff --git a/acqui/invoice.pl b/acqui/invoice.pl index d38a83d217b..52af61b9e75 100755 --- a/acqui/invoice.pl +++ b/acqui/invoice.pl @@ -287,27 +287,28 @@ push @foot_loop, map { $_ } values %foot; my $shipmentcost_budgetid = $details->{shipmentcost_budgetid}; # build budget list -my $budget_loop = []; -my $budgets = GetBudgetHierarchy(); +my %budget_loops; +my $budgets = GetBudgetHierarchy; foreach my $r ( @{$budgets} ) { next unless ( CanUserUseBudget( $loggedinuser, $r, $flags ) ); - my $selected = $shipmentcost_budgetid ? $r->{budget_id} eq $shipmentcost_budgetid : 0; - - push @{$budget_loop}, - { + unless ( defined $budget_loops{ $r->{budget_period_id} } ) { + $budget_loops{ $r->{budget_period_id} }->{description} = $r->{budget_period_description}; + $budget_loops{ $r->{budget_period_id} }->{active} = $r->{budget_period_active}; + $budget_loops{ $r->{budget_period_id} }->{funds} = []; + } + push @{ $budget_loops{ $r->{budget_period_id} }->{funds} }, { b_id => $r->{budget_id}, b_txt => $r->{budget_name}, - b_active => $r->{budget_period_active}, - selected => $selected, + b_code => $r->{budget_code}, b_sort1_authcat => $r->{'sort1_authcat'}, b_sort2_authcat => $r->{'sort2_authcat'}, - }; + b_active => $r->{budget_period_active}, + b_sel => $shipmentcost_budgetid ? $r->{budget_id} eq $shipmentcost_budgetid : 0, + b_level => $r->{budget_level}, + }; } -@{$budget_loop} = - sort { uc( $a->{b_txt} ) cmp uc( $b->{b_txt} ) } @{$budget_loop}; - my $adjustments = Koha::Acquisition::Invoice::Adjustments->search( { invoiceid => $details->{'invoiceid'} } ); if ($adjustments) { $template->param( adjustments => $adjustments ); } @@ -337,7 +338,7 @@ $template->param( total_tax_included_shipment => $total_tax_included + $shipmentcost, invoiceincgst => $bookseller->invoiceincgst, currency => $active_currency, - budgets => $budget_loop, + budget_loop => \%budget_loops, budget => GetBudget($shipmentcost_budgetid), has_invoice_unitprice => $has_invoice_unitprice, ); diff --git a/acqui/neworderempty.pl b/acqui/neworderempty.pl index b68ace84742..a1b1a0598e8 100755 --- a/acqui/neworderempty.pl +++ b/acqui/neworderempty.pl @@ -333,11 +333,16 @@ my $patron = Koha::Patrons->find($loggedinuser)->unblessed; my $budget = GetBudget($budget_id); # build budget list -my $budget_loop = []; -my $budgets = GetBudgetHierarchy; +my %budget_loops; +my $budgets = GetBudgetHierarchy; foreach my $r ( @{$budgets} ) { next unless ( CanUserUseBudget( $patron, $r, $userflags ) ); - push @{$budget_loop}, { + unless ( defined $budget_loops{ $r->{budget_period_id} } ) { + $budget_loops{ $r->{budget_period_id} }->{description} = $r->{budget_period_description}; + $budget_loops{ $r->{budget_period_id} }->{active} = $r->{budget_period_active}; + $budget_loops{ $r->{budget_period_id} }->{funds} = []; + } + push @{ $budget_loops{ $r->{budget_period_id} }->{funds} }, { b_id => $r->{budget_id}, b_txt => $r->{budget_name}, b_sort1_authcat => $r->{'sort1_authcat'}, @@ -484,7 +489,7 @@ $template->param( author => $data->{'author'}, publicationyear => $data->{'publicationyear'} ? $data->{'publicationyear'} : $data->{'copyrightdate'}, editionstatement => $data->{'editionstatement'}, - budget_loop => $budget_loop, + budget_loop => \%budget_loops, isbn => $data->{'isbn'}, ean => $data->{'ean'}, seriestitle => $data->{'seriestitle'}, diff --git a/acqui/orderreceive.pl b/acqui/orderreceive.pl index 06564c730a3..ba9931b8bc3 100755 --- a/acqui/orderreceive.pl +++ b/acqui/orderreceive.pl @@ -197,7 +197,7 @@ foreach my $budget ( @{$budgets} ) { b_level => $budget->{budget_level}, }; } -$template->{'VARS'}->{'budget_loops'} = \%budget_loops; +$template->{'VARS'}->{'budget_loop'} = \%budget_loops; my $op = $input->param('op'); if ( $op and $op eq 'cud-edit' ) { diff --git a/acqui/parcels.pl b/acqui/parcels.pl index ee3e3d6a060..888a4676304 100755 --- a/acqui/parcels.pl +++ b/acqui/parcels.pl @@ -204,20 +204,27 @@ if ($count_parcels) { } # build budget list -my $budget_loop = []; -my $budgets = GetBudgetHierarchy; +my %budget_loops; +my $budgets = GetBudgetHierarchy; foreach my $r ( @{$budgets} ) { next unless ( CanUserUseBudget( $loggedinuser, $r, $flags ) ); - push @{$budget_loop}, { - b_id => $r->{budget_id}, - b_txt => $r->{budget_name}, - b_active => $r->{budget_period_active}, + unless ( defined $budget_loops{ $r->{budget_period_id} } ) { + $budget_loops{ $r->{budget_period_id} }->{description} = $r->{budget_period_description}; + $budget_loops{ $r->{budget_period_id} }->{active} = $r->{budget_period_active}; + $budget_loops{ $r->{budget_period_id} }->{funds} = []; + } + push @{ $budget_loops{ $r->{budget_period_id} }->{funds} }, { + b_id => $r->{budget_id}, + b_txt => $r->{budget_name}, + b_code => $r->{budget_code}, + b_sort1_authcat => $r->{'sort1_authcat'}, + b_sort2_authcat => $r->{'sort2_authcat'}, + b_active => $r->{budget_period_active}, + b_sel => ( $r->{budget_id} == $shipmentcost_budgetid ) ? 1 : 0, + b_level => $r->{budget_level}, }; } -@{$budget_loop} = - sort { uc( $a->{b_txt} ) cmp uc( $b->{b_txt} ) } @{$budget_loop}; - $template->param( orderby => $order, filter => $code, @@ -229,7 +236,7 @@ $template->param( shipmentdate_today => dt_from_string, booksellerid => $booksellerid, GST => C4::Context->preference('TaxRates'), - budgets => $budget_loop, + budgets => \%budget_loops, ); output_html_with_http_headers $input, $cookie, $template->output; diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/budgets_loop.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/budgets_loop.inc new file mode 100644 index 00000000000..9ffa8510abf --- /dev/null +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/budgets_loop.inc @@ -0,0 +1,28 @@ +[% FOREACH budget_period_id IN budget_loop.keys %] + [% SET budget_period = budget_loop.$budget_period_id %] + + [% FOREACH budget_loo IN budget_period.funds %] + [% level_indent_cnt = 0 %] + [% level_indent = "" %] + [% WHILE level_indent_cnt < budget_loo.b_level %] + [% level_indent = level_indent _ " -- " %] + [% level_indent_cnt = level_indent_cnt +1 %] + [% END %] + [% IF ( budget_loo.b_sel ) %] + [% active_count = 0 #select no other fund %] + + [% ELSIF active_count==1 && budget_loo.b_active %] + + [% ELSE %] + [% bdgclass=budget_loo.b_active? "": inactive_class | html %] + + [% END %] + [% END %] + +[% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt index d0e834b57a3..684751f1627 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt @@ -179,6 +179,7 @@ [% ELSIF ( biblio_lis.overlay_status == 'auto_match' ) %] Match found [% ELSE %] +<<<<<<< HEAD [% biblio_lis.overlay_status | html %] [% END %] [% IF ( biblio.match_biblionumber ) %] @@ -239,41 +240,7 @@ [% END %] @@ -302,6 +269,41 @@ [% ELSE %] +======= + + + + [% END %] + +
  • + + +
  • +
  • + + +
  • + + [% IF ( biblio.iteminfos.size ) %] +
    + [% IF biblio.item_error %]Item records could not be processed because the number of item fields was uneven.[% END %] + [% FOREACH item IN biblio.iteminfos %] +
    + Item record [% item.item_id | html %] +
      +
    1. + + @@ -409,21 +411,7 @@ disabled="disabled" > - [% FOREACH budget_loo IN budget_loop %] - [% IF ( budget_loo.b_active ) %] - [% IF ( budget_loo.b_id ) == ( item.budget_id ) %] - - [% ELSE %] - - [% END %] - [% ELSE %] - [% IF ( budget_loo.b_id ) == ( item.budget_id ) %] - - [% ELSE %] - - [% END %] - [% END %] - [% END %] + [% INCLUDE 'budgets_loop.inc' inactive_class = "budget_item_inactive" %] Required
    2. @@ -602,21 +590,7 @@ diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt index c2aa5452452..4a667e1478b 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt @@ -215,17 +215,7 @@ diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt index 91ef1acade2..87c097aabfc 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt @@ -10,7 +10,7 @@ [% END %] @@ -527,13 +527,7 @@
      diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt index 5516e05f1c8..850fa1e0d0b 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt @@ -584,35 +584,8 @@
    3. - [% active_count = 0 %] - [% IF !ordernumber %] - [% FOREACH budget_loo IN budget_loop %] - [% active_count= active_count + budget_loo.b_active %] - [% END %] - [% END %] Required diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt index b36f1d39b92..b5b532976ee 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt @@ -284,44 +284,7 @@ - [% FOREACH budget_period_id IN budget_loops.keys %] - [% SET budget_period = budget_loops.$budget_period_id %] - [% SET optgroup_class = "" %] - [% SET optgroup_label = budget_period.description %] - [% IF budget_period.active %] - [% SET optgroup_class = "inactive_budget" %] - [% SET optgroup_label = t("{budget_description} (Inactive)", {budget_description = budget_period.description}) %] - [% END %] - - - [% FOREACH budget_loo IN budget_period.funds %] - [% level_indent_cnt = 0 %] - [% level_indent = "" %] - [% WHILE level_indent_cnt < budget_loo.b_level %] - [% level_indent = level_indent _ " -- " %] - [% level_indent_cnt = level_indent_cnt +1 %] - [% END %] - - [% SET bdgclass = "" %] - [% IF ( budget_loo.b_sel ) %] - [% active_count = 0 #select no other fund %] - [% ELSIF active_count==1 && budget_loo.b_active %] - - [% ELSE %] - [% bdgclass=budget_loo.b_active? "": "inactive_budget" | html %] - [% END %] - - - [% END %] - - [% END %] + [% INCLUDE 'budgets_loop.inc' inactive_class = "inactive_budget" %] Required
    4. diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt index 08b89893a13..d76c84f2923 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt @@ -182,13 +182,7 @@ diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt index c6b25551d24..930b6cf71f4 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt @@ -1218,19 +1218,11 @@ [% ELSE %] [% END %] - [% FOREACH budget IN sugg_budgets %] - [% IF ( budget.selected ) %] - - [% ELSIF ( budget.b_active ) %] - - [% ELSE %] - - [% END %] - [% END %] + [% INCLUDE 'budgets_loop.inc' inactive_class = "b_inactive" %] - + [% END %] [% MACRO jsinclude BLOCK %] diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl index 39521c6495c..4364ebb0e2d 100755 --- a/suggestion/suggestion.pl +++ b/suggestion/suggestion.pl @@ -545,21 +545,28 @@ my $patron_reason_loop = GetAuthorisedValues("OPAC_SUG"); $template->param( patron_reason_loop => $patron_reason_loop ); # Budgets for suggestion add or edition -my $sugg_budget_loop = []; -my $sugg_budgets = GetBudgetHierarchy(); +my %budget_loops; +my $sugg_budgets = GetBudgetHierarchy; foreach my $r ( @{$sugg_budgets} ) { next unless ( CanUserUseBudget( $borrowernumber, $r, $userflags ) ); - my $selected = ( $$suggestion_ref{budgetid} && $r->{budget_id} eq $$suggestion_ref{budgetid} ) ? 1 : 0; - push @{$sugg_budget_loop}, - { - b_id => $r->{budget_id}, - b_txt => $r->{budget_name}, - b_active => $r->{budget_period_active}, - selected => $selected, - }; + unless ( defined $budget_loops{ $r->{budget_period_id} } ) { + $budget_loops{ $r->{budget_period_id} }->{description} = $r->{budget_period_description}; + $budget_loops{ $r->{budget_period_id} }->{active} = $r->{budget_period_active}; + $budget_loops{ $r->{budget_period_id} }->{funds} = []; + } + push @{ $budget_loops{ $r->{budget_period_id} }->{funds} }, { + b_id => $r->{budget_id}, + b_txt => $r->{budget_name}, + b_code => $r->{budget_code}, + b_sort1_authcat => $r->{'sort1_authcat'}, + b_sort2_authcat => $r->{'sort2_authcat'}, + b_active => $r->{budget_period_active}, + b_sel => ( $$suggestion_ref{budgetid} && $r->{budget_id} eq $$suggestion_ref{budgetid} ) ? 1 : 0, + b_level => $r->{budget_level}, + }; } -@{$sugg_budget_loop} = sort { uc( $a->{b_txt} ) cmp uc( $b->{b_txt} ) } @{$sugg_budget_loop}; -$template->param( sugg_budgets => $sugg_budget_loop ); + +$template->param( budget_loop => \%budget_loops ); if ( $suggestion_ref->{STATUS} ) { $template->param( -- 2.39.5