From 37a9311a6e577f7fab6bfcbf5f7c24489a3f9bbd Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 16 Jul 2025 11:59:17 +0200 Subject: [PATCH] Bug 40405: Set decreaseLoanHighHolds\* to 0 When reviewing the different sysprefs that had "NULL" as default, I only found those 2 occurrences that could be problematic. I think we should default to 0 here. --- C4/Circulation.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index f9cf48a6058..0d9d85765f1 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -1456,7 +1456,7 @@ sub checkHighHolds { $return_data->{outstanding} = $holds->count(); my $decreaseLoanHighHoldsControl = C4::Context->preference('decreaseLoanHighHoldsControl'); - my $decreaseLoanHighHoldsValue = C4::Context->preference('decreaseLoanHighHoldsValue'); + my $decreaseLoanHighHoldsValue = C4::Context->preference('decreaseLoanHighHoldsValue') || 0; my $decreaseLoanHighHoldsIgnoreStatuses = C4::Context->preference('decreaseLoanHighHoldsIgnoreStatuses'); my @decreaseLoanHighHoldsIgnoreStatuses = split( /,/, $decreaseLoanHighHoldsIgnoreStatuses ); @@ -1528,7 +1528,7 @@ sub checkHighHolds { # overrides decreaseLoanHighHoldsDuration syspref $duration = $rule; } else { - $duration = C4::Context->preference('decreaseLoanHighHoldsDuration'); + $duration = C4::Context->preference('decreaseLoanHighHoldsDuration') || 0; } my $reduced_datedue = $calendar->addDuration( $issuedate, $duration ); $reduced_datedue->set_hour( $orig_due->hour ); -- 2.34.1