From 0e45e1ce13cd614f3ec7220622caca7067062af2 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 16 Jul 2025 12:19:44 +0200 Subject: [PATCH] Bug 40407: Remove legacy "pre-wrap" versions From https://css-tricks.com/snippets/css/make-pre-text-wrap/ /* Browser specific (not valid) styles to make preformatted text wrap */ pre { white-space: pre-wrap; /* css-3 */ white-space: -moz-pre-wrap; /* Mozilla, since 1999 */ white-space: -pre-wrap; /* Opera 4-6 */ white-space: -o-pre-wrap; /* Opera 7 */ word-wrap: break-word; /* Internet Explorer 5.5+ */ } ... I think it's now safe to remove the backward compatibility versions and simply keep pre-wrap. Test plan (from bug 921)0: * place a hold on a title with a very very long title or author * mark it as "waiting for pickup" by doing a checkin * go to command line interface, and run * misc/cronjobs/gather_print_notices.pl /tmp * misc/cronjobs/printoverdues.sh /tmp * if your title/author is long enough, it's splitted on 2 lines with this patch (it is not before this patch) It will also remove the warnings from t/db_dependent/Patron/Borrower_Discharge.t WARNING: Ignored `white-space: -moz-pre-wrap` at 6:14, invalid value. WARNING: Ignored `white-space: -o-pre-wrap` at 7:14, invalid value. WARNING: Ignored `word-wrap: break-work` at 8:14, invalid value. --- koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt | 3 --- misc/cronjobs/overdue_notices.pl | 3 --- 2 files changed, 6 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt index d7ccd43ea54..44a6637d26a 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt @@ -14,9 +14,6 @@ .message { page-break-after: always } pre { font-family: monospace } pre {white-space: pre-wrap;} - pre {white-space: -moz-pre-wrap;} - pre {white-space: -o-pre-wrap;} - pre {word-wrap: break-work;} --> diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl index 298e1ed414a..f0ca534e5d6 100755 --- a/misc/cronjobs/overdue_notices.pl +++ b/misc/cronjobs/overdue_notices.pl @@ -1034,9 +1034,6 @@ sub _get_html_start { "; -- 2.34.1