From e7969f429ebc00c69d03879f76f03e0d34cead63 Mon Sep 17 00:00:00 2001 From: Pedro Amorim Date: Tue, 15 Jul 2025 12:47:29 +0000 Subject: [PATCH] Bug 40395: Add checkboxes column to holds table Test plan, k-t-d, patches applied: 1) Search for 'music': http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=music 2) Click the 'Select all' link on the left of the search toolbar 3) Click the 'Place hold' button on the same toolbar 4) On the patron input, add 'koha' 5) You need to pick the 'Pickup location' specifically for each hold. Click 'Place holds' 6) On this screen (reserve/request.pl) ensure the table(s) work. Selecting all works. Canceling selected works (it doesn't refresh immediatelly, it's a background job). Suspend works as before, sorting, etc. 7) Now visit the patron details page: http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51 8) Click the 'Holds' tab. 9) Verify we now have a checkbox column at the start. 10) Test that selecting multiple holds and canceling selected works. Same for suspending. 11) Test the canceling or suspending a specific hold works. 12) Test that this table is compatible with AutoResumeSuspendedHolds sys pref i.e. you're unable to set a resume date when suspending in bulk or single if this sys pref is turned off. 13) Repeat steps 8-12 but for the circulation page from patron details at: http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 14) Ensure tests added for API REST endpoint added here pass: prove t/db_dependent/api/v1/holds.t --- .../prog/en/includes/patron-detail-tabs.inc | 3 ++- koha-tmpl/intranet-tmpl/prog/js/holds.js | 14 ++++++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc index 0322d532061..b59888eca45 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc @@ -146,9 +146,10 @@
[% INCLUDE 'csrf-token.inc' %] - +
+ diff --git a/koha-tmpl/intranet-tmpl/prog/js/holds.js b/koha-tmpl/intranet-tmpl/prog/js/holds.js index b6e9d988380..7669dc0f35e 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/holds.js +++ b/koha-tmpl/intranet-tmpl/prog/js/holds.js @@ -158,6 +158,20 @@ $(document).ready(function () { autoWidth: false, dom: '<"table_controls"B>rt', columns: [ + { + orderable: false, + data: function (oObj) { + return ( + '' + ); + }, + }, { data: { _: "reservedate_formatted", -- 2.39.5
Hold date Title Call number