From 2980b6f17f1e301ac53798ca9457ac6b6230e85e Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 16 Jul 2025 12:33:58 +0200 Subject: [PATCH] Bug 40409: Remove warnings from t/db_dependent/Overdues.t The tests was wrong, we should make sure the item has been checked in. We were missing the mock userenv: Can't use an undefined value as a HASH reference at /kohadevbox/koha/C4/Circulation.pm line 2744. at /kohadevbox/koha/C4/Circulation.pm line 2787 --- t/db_dependent/Overdues.t | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/Overdues.t b/t/db_dependent/Overdues.t index a65bacbe10b..f17ee28d18e 100755 --- a/t/db_dependent/Overdues.t +++ b/t/db_dependent/Overdues.t @@ -1,7 +1,8 @@ #!/usr/bin/perl; use Modern::Perl; -use Test::More tests => 18; +use Test::More tests => 19; +use Test::NoWarnings; use Test::Warn; use C4::Context; @@ -549,6 +550,7 @@ subtest 'UpdateFine tests' => sub { { order_by => { '-asc' => 'accountlines_id' } } ); is( $fines->count, 4, "New amount should be 0 so no fine added" ); + t::lib::Mocks::mock_userenv( { patron => $patron_1 } ); my @r = C4::Circulation::AddReturn( $item_1->barcode, $item_1->homebranch, 1 ); is( $r[1]->{WasReturned}, 1, "Returning the item and forgiving fines succeeds" ); -- 2.34.1