From 8e66b2a77b1ffab577bed121cc3f550d6c0454b3 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Wed, 16 Jul 2025 12:17:31 +0000 Subject: [PATCH] Bug 40412: Update the patron card export process to avoid Greybox modal This patch updates the patron card export process to eliminate the use of the Greybox modal, opting to move from page to page through the process. Tangentially related: I updated the DataTables table configuration of the tables on the patron card batch management page and patron card batch edit page in order to remove the DataTables "Export" button because of the possibility that its presence might be confusing. To test apply the patch and go to Tools -> Patron card creator. - Create more than one batch add multiple patrons to each. - From the patron card batches page, test the process of exporting patron cards, observing at each step the page title and breadcrumbs. - Check a box next to a single batch and click the "Export selected batches" button at the bottom. - Check multiple boxes and click "Export selected batches." - Click "Edit" on one of the batches - In the list of patrons, check one or more checkboxes, and click "Export selected card(s)." - Click an individual "Export" button from the list of patrons. - Click "Export card batch". - Select a list from the "Patron list" dropdown and click "Export from patron list." - In each case, you should be forwarded to a new page for choosing patron card options. - After submitting the form, you should be forwarded to another page where you can download the batch as a PDF. - Test the new "Return to patron card batches" to confirm that it takes you to the patron card batches page. Sponsored-by: Athens County Public Libraries Signed-off-by: Caroline Cyr La Rose --- .../prog/en/modules/patroncards/edit-batch.tt | 8 +- .../prog/en/modules/patroncards/manage.tt | 6 +- .../prog/en/modules/patroncards/print.tt | 82 +++++++++++-------- 3 files changed, 54 insertions(+), 42 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt index 1ee578a3b22..bcbed141cdf 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt @@ -173,7 +173,6 @@ [% END %] [% MACRO jsinclude BLOCK %] - [% INCLUDE 'greybox.inc' %] [% INCLUDE 'datatables.inc' %] [% Asset.js("js/tools-menu.js") | $raw %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/print.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/print.tt index 7ee41c37c8d..21f00cccef3 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/print.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/print.tt @@ -3,22 +3,43 @@ [% PROCESS 'i18n.inc' %] [% SET footerjs = 1 %] [% INCLUDE 'doc-head-open.inc' %] -[% FILTER collapse %] - [% t("Patron card printing/exporting") | html %] +<title> + [% FILTER collapse %] + [% t("Export") | html %] › [% t("Patron cards") | html %] › [% t("Tools") | html %] › [% t("Koha") | html %] - [% END %] -[% INCLUDE 'doc-head-close.inc' popup => 1 %] + [% END %] + +[% INCLUDE 'doc-head-close.inc' %] - -
-

Patron card printing/exporting

+ +[% WRAPPER 'header.inc' %] + [% INCLUDE 'cat-search.inc' %] +[% END %] + +[% WRAPPER 'sub-header.inc' %] + [% WRAPPER breadcrumbs %] + [% WRAPPER breadcrumb_item %] + Tools + [% END %] + [% WRAPPER breadcrumb_item %] + Patron card creator + [% END %] + [% WRAPPER breadcrumb_item %] + Batches + [% END %] + [% WRAPPER breadcrumb_item bc_active= 1 %] + Export + [% END %] + [% END #/ WRAPPER breadcrumbs %] +[% END #/ WRAPPER sub-header.inc %] + +[% WRAPPER 'main-container.inc' %] +

Patron card export

[% IF ( batches ) %]
-

Click on the following link(s) to download the exported batch(es).

-
+

Click any of the following links to download the exported batch

+
[% FOREACH batche IN batches %] [% IF ( batche.label_ids ) %] [% batche.card_count | html %] Single patron cards @@ -49,22 +70,25 @@

[% END %] [% END %] -
+
- + Return to patron card batches
[% ELSIF ( patronlist_id && template_id && layout_id ) %]
-

Click on the link to download the patron cards from the patron list.

-

- label_patronlist_[% patronlist_id | html %].pdf -

+

Click any of the following links to download the exported batch

+
[% ELSE %]

@@ -143,21 +167,9 @@ [% END %] - - +[% END %] [% MACRO jsinclude BLOCK %] - [% INCLUDE 'greybox.inc' %] - [% END %] -[% INCLUDE 'popup-bottom.inc' %] +[% INCLUDE 'intranet-bottom.inc' %] -- 2.43.0