From 58cec3d30af962f0984ff2e493d79f52148b00d5 Mon Sep 17 00:00:00 2001 From: Emily Lamancusa Date: Fri, 18 Jul 2025 14:35:52 -0400 Subject: [PATCH] Bug 39502: (QA follow-up) Remove title attribute as well When an element should be ignored by screen readers, it should have no title attribute or an empty title attribute, in addition to a null alt attribute. Signed-off-by: Emily Lamancusa --- .../tables/items/catalogue_detail.inc | 2 +- .../prog/en/modules/catalogue/results.tt | 2 +- .../prog/en/modules/virtualshelves/shelves.tt | 2 +- .../en/xslt/MARC21slim2intranetResults.xsl | 20 +++++++++---------- .../bootstrap/en/modules/opac-shelves.tt | 2 +- 5 files changed, 14 insertions(+), 14 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc index 7ea4270e71..fdbfec2cef 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc @@ -396,7 +396,7 @@ [% UNLESS noItemTypeImages %] let image_location = item_type_image_locations[row.item_type_id]; node += image_location - ? ' '.format(escape_str(image_location), escape_str(item_type_description), escape_str(item_type_description)) + ? ' '.format(escape_str(image_location), escape_str(item_type_description), escape_str(item_type_description)) : ''; [% END %] node += '%s'.format(escape_str(item_type_description)); diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt index 8a703f516b..680dec13e0 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt @@ -781,7 +781,7 @@ [% END %]
  • [% IF item_level_itypes && !noItemTypeImages && items_loo.imageurl %] - [% items_loo.description | html %] + [% END %] [% IF ( items_loo.branchname ) %] [% items_loo.branchname | html %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt index 8853414337..05052171c4 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt @@ -351,7 +351,7 @@ [% UNLESS ( item_level_itypes ) %] [% UNLESS ( noItemTypeImages || !itemsloo.imageurl ) %] - + [% END %] [% itemsloo.description | html %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl index 0e7b2cccb9..b03a8c1f9d 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl +++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl @@ -512,20 +512,20 @@ book Text serial Continuing resource - Article + Article - book Text - Kit - Mixed materials - Computer file - Map + Text + Kit + Mixed materials + Computer file + Map Film Picture - Object - Score - Sound - Music + Object + Score + Sound + Music diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt index e7534fcc87..875a88da23 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt @@ -401,7 +401,7 @@ [% UNLESS ( item_level_itypes ) %] [% UNLESS ( Koha.Preference('OpacNoItemTypeImages') ) %] - + [% END %] [% itemsloo.description | html %] -- 2.39.5