From 77cfdf458a3de5e7583d720cbca1f4540484a96f Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Tue, 17 Oct 2023 15:48:16 +0000 Subject: [PATCH] Bug 22632: (follow-up) Use PATRON_MERGE as log action Signed-off-by: Andrew Fuerste Henry --- Koha/Patron.pm | 2 +- koha-tmpl/intranet-tmpl/prog/en/includes/action-logs.inc | 2 ++ koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt | 2 +- t/db_dependent/Koha/Patron/Log.t | 6 +++--- 4 files changed, 7 insertions(+), 5 deletions(-) diff --git a/Koha/Patron.pm b/Koha/Patron.pm index c74ab3cc164..6bfefe25377 100644 --- a/Koha/Patron.pm +++ b/Koha/Patron.pm @@ -804,7 +804,7 @@ sub merge_with { . $self->firstname . " " . $self->surname . " (" . $self->cardnumber . ")"; - logaction( "MEMBERS", "Merge", $self->id, $info ); + logaction( "MEMBERS", "PATRON_MERGE", $self->id, $info ); } } } diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/action-logs.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/action-logs.inc index dae105f20e4..1ab3e72af80 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/action-logs.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/action-logs.inc @@ -133,6 +133,8 @@ Run [% CASE 'End' %] End + [% CASE 'PATRON_MERGE' %] + Merge [% CASE 'EDIT_MAPPINGS' %] Edit mappings [% CASE 'RESET_MAPPINGS' %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt index 6eb1659d988..5df1493c8b7 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt @@ -147,7 +147,7 @@ [% END %] - [% FOREACH actx IN [ 'ADD' 'DELETE' 'MODIFY' 'ISSUE' 'RETURN' 'RENEW' 'CREATE' 'CANCEL' 'FILL' 'SUSPEND' 'RESUME' 'ADDCIRCMESSAGE' 'MODCIRCMESSAGE' 'DELCIRCMESSAGE' 'STATUS_CHANGE' 'PATRON_NOTICE' 'CHANGE PASS' 'RESET PASS' 'Run' 'End' 'Merge' 'EDIT_MAPPINGS' 'RESET_MAPPINGS' 'ADD_BASKET' 'MODIFY_BASKET' 'MODIFY_BASKET_HEADER' 'MODIFY_BASKET_USERS' 'CLOSE_BASKET' 'APPROVE_BASKET' 'REOPEN_BASKET' 'CANCEL_ORDER' 'CREATE_ORDER' 'MODIFY_ORDER' 'CREATE_INVOICE_ADJUSTMENT' 'UPDATE_INVOICE_ADJUSTMENT' 'DELETE_INVOICE_ADJUSTMENT' 'RECEIVE_ORDER' 'MODIFY_BUDGET' 'MODIFY_FUND' 'CREATE_FUND' 'DELETE_FUND' 'ACQUISITION CLAIM' 'ACQUISITION ORDER' 'OVERDUE' 'EXPIRE' 'CREATE_RESTRICTION' 'MODIFY_RESTRICTION' 'DELETE_RESTRICTION' 'MODIFY_CARDNUMBER' ] %] + [% FOREACH actx IN [ 'ADD' 'DELETE' 'MODIFY' 'ISSUE' 'RETURN' 'RENEW' 'CREATE' 'CANCEL' 'FILL' 'SUSPEND' 'RESUME' 'ADDCIRCMESSAGE' 'MODCIRCMESSAGE' 'DELCIRCMESSAGE' 'STATUS_CHANGE' 'PATRON_NOTICE' 'CHANGE PASS' 'RESET PASS' 'Run' 'End' 'PATRON_MERGE' 'EDIT_MAPPINGS' 'RESET_MAPPINGS' 'ADD_BASKET' 'MODIFY_BASKET' 'MODIFY_BASKET_HEADER' 'MODIFY_BASKET_USERS' 'CLOSE_BASKET' 'APPROVE_BASKET' 'REOPEN_BASKET' 'CANCEL_ORDER' 'CREATE_ORDER' 'MODIFY_ORDER' 'CREATE_INVOICE_ADJUSTMENT' 'UPDATE_INVOICE_ADJUSTMENT' 'DELETE_INVOICE_ADJUSTMENT' 'RECEIVE_ORDER' 'MODIFY_BUDGET' 'MODIFY_FUND' 'CREATE_FUND' 'DELETE_FUND' 'ACQUISITION CLAIM' 'ACQUISITION ORDER' 'OVERDUE' 'EXPIRE' 'CREATE_RESTRICTION' 'MODIFY_RESTRICTION' 'DELETE_RESTRICTION' 'MODIFY_CARDNUMBER' ] %] [% IF actions.grep(actx).size %] sub { my $results = $keeper->merge_with([ $borrower1->{borrowernumber}, $borrower2->{borrowernumber} ]); - my $log=GetLogs("","","",["MEMBERS"],["Merge"],$keeper->id,""); + my $log=GetLogs("","","",["MEMBERS"],["PATRON_MERGE"],$keeper->id,""); my $info_borrower1 = $borrower1->{firstname} . " " . $borrower1->{surname} . " (" . $borrower1->{cardnumber} . ") has been merged into " . $keeper->firstname . " " . $keeper->surname . " (" . $keeper->cardnumber . ")"; @@ -63,7 +63,7 @@ subtest 'Test Koha::Patrons::merge' => sub { $results = $keeper->merge_with([ $borrower3->{borrowernumber}, $borrower4->{borrowernumber} ]); - $log=GetLogs("","","",["MEMBERS"],["Merge"],$keeper->id,""); + $log=GetLogs("","","",["MEMBERS"],["PATRON_MERGE"],$keeper->id,""); $info_log = $log->[0]{info}; is($info_log,undef,"GetLogs didn't returns results in the log viewer for the merge of " . $borrower3->{borrowernumber}); @@ -73,4 +73,4 @@ subtest 'Test Koha::Patrons::merge' => sub { is($info_log,undef,"GetLogs didn't returns results in the log viewer for the merge of " . $borrower4->{borrowernumber}); }; -$schema->storage->txn_rollback; \ No newline at end of file +$schema->storage->txn_rollback; -- 2.39.5