From c796d2fa8ceb754a0167d86206573f12c3820f67 Mon Sep 17 00:00:00 2001 From: Yvonne Waterman Date: Thu, 17 Jul 2025 23:42:31 +0000 Subject: [PATCH] Bug 31930: Ignore whitespace before and after barcodes Decoded the barcode in add items to collection. Test plan: 1. Go to Tools -> Rotating collections 2. Create a rotating collection 3. Chose Actions -> Manage items 4. Paste a barcode and put some spaces around it, for example " 39999000010053 " 5. Click Submit => Shown an error, no item with matching barcode found, though the barcode is printed without all the whitespace 6. Apply patch 7. Repeat steps 1 - 5, barcode should be accepted Signed-off-by: David Nind Signed-off-by: Lucas Gass --- rotating_collections/addItems.pl | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/rotating_collections/addItems.pl b/rotating_collections/addItems.pl index ef9c5eb7443..4f86c1de514 100755 --- a/rotating_collections/addItems.pl +++ b/rotating_collections/addItems.pl @@ -18,8 +18,9 @@ use Modern::Perl; -use C4::Output qw( output_html_with_http_headers ); -use C4::Auth qw( get_template_and_user ); +use C4::Output qw( output_html_with_http_headers ); +use C4::Auth qw( get_template_and_user ); +use C4::Circulation qw( barcodedecode ); use C4::Context; use C4::RotatingCollections; @@ -42,8 +43,9 @@ if ( defined $op and $op eq 'cud-add' ) { ## Add the given item to the collection - my $colId = $query->param('colId'); - my $barcode = $query->param('barcode'); + my $colId = $query->param('colId'); + my $barcode = $query->param('barcode'); + $barcode = barcodedecode($barcode); my $removeItem = $query->param('removeItem'); my $item = Koha::Items->find( { barcode => $barcode } ); my $itemnumber = $item ? $item->itemnumber : undef; -- 2.39.5