From 17444dda0fcd6d1b2b4652fdef245019103e018e Mon Sep 17 00:00:00 2001 From: Pedro Amorim Date: Mon, 28 Jul 2025 11:08:06 +0000 Subject: [PATCH] Bug 40517: (QA follow-up): Cleanup obsolete code The patch 'Move creation of hold group into Patron class' is moving the creation of the hold group logic to the Patron.pm class file but it didn't remove all the obsolete code. This is fixed here. Signed-off-by: Anneli --- C4/Reserves.pm | 2 -- reserve/placerequest.pl | 4 ---- 2 files changed, 6 deletions(-) diff --git a/C4/Reserves.pm b/C4/Reserves.pm index 71caf04622..52ac6c6cea 100644 --- a/C4/Reserves.pm +++ b/C4/Reserves.pm @@ -194,7 +194,6 @@ sub AddReserve { my $itemtype = $params->{itemtype}; my $non_priority = $params->{non_priority}; my $item_group_id = $params->{item_group_id}; - my $hold_group_id = $params->{hold_group_id}; $resdate ||= dt_from_string; @@ -257,7 +256,6 @@ sub AddReserve { itemtype => $itemtype, item_level_hold => $checkitem ? 1 : 0, non_priority => $non_priority ? 1 : 0, - hold_group_id => $hold_group_id, } )->store(); $hold->set_waiting() if $found && $found eq 'W'; diff --git a/reserve/placerequest.pl b/reserve/placerequest.pl index cd096b80bf..49a62685f1 100755 --- a/reserve/placerequest.pl +++ b/reserve/placerequest.pl @@ -52,7 +52,6 @@ my $non_priority = $input->param('non_priority'); my $op = $input->param('op') || q{}; my $multi_holds = $input->param('multi_holds'); my $hold_group_param = $input->param('hold_group') || undef; -my $hold_group; my $patron = Koha::Patrons->find($borrowernumber); @@ -107,7 +106,6 @@ if ( $op eq 'cud-placerequest' && $patron ) { found => undef, itemtype => $itemtype, non_priority => $non_priority, - hold_group_id => $hold_group ? $hold_group->id : undef, } ); @@ -137,7 +135,6 @@ if ( $op eq 'cud-placerequest' && $patron ) { found => undef, itemtype => $itemtype, non_priority => $non_priority, - hold_group_id => $hold_group ? $hold_group->id : undef, } ); push @successful_hold_ids, $reserve_id; @@ -162,7 +159,6 @@ if ( $op eq 'cud-placerequest' && $patron ) { itemtype => $itemtype, non_priority => $non_priority, item_group_id => $item_group_id, - hold_group_id => $hold_group ? $hold_group->id : undef, } ); push @successful_hold_ids, $reserve_id; -- 2.39.5