From 72883e7c8a1d4f00bf76cc7bc3b76af0b2d75881 Mon Sep 17 00:00:00 2001 From: Pedro Amorim Date: Wed, 30 Jul 2025 11:32:26 +0000 Subject: [PATCH] Bug 40552: Preparation: Move patron page logic for reusability --- koha-tmpl/intranet-tmpl/prog/js/holds.js | 8 +------- koha-tmpl/intranet-tmpl/prog/js/staff-global.js | 15 +++++++++++++++ 2 files changed, 16 insertions(+), 7 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/holds.js b/koha-tmpl/intranet-tmpl/prog/js/holds.js index 394e06d63d8..3c9d419b6eb 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/holds.js +++ b/koha-tmpl/intranet-tmpl/prog/js/holds.js @@ -107,13 +107,7 @@ function display_pickup_location(state) { /* global __ borrowernumber SuspendHoldsIntranet */ $(document).ready(function () { - var url = window.location.href; - let patron_page; - if (url.indexOf("/circ/circulation.pl?borrowernumber=") !== -1) - patron_page = "circ"; - else if (url.indexOf("/members/moremember.pl?borrowernumber=") !== -1) - patron_page = "borrower"; - + let patron_page = holds_table_patron_page(); function suspend_hold(hold_ids, end_date) { var params = { hold_ids: hold_ids }; if (end_date !== null && end_date !== "") params.end_date = end_date; diff --git a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js index ed6f0b35f7b..2dff3328bd2 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js +++ b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js @@ -1005,6 +1005,21 @@ function toggleBtnIcon(element, start, replacement) { }); } +/** + * Determines which patron page we are on based on the URL + * @return {string} The patron page we are on, "circ" or "borrower", or null + * if neither page is matched + */ +function holds_table_patron_page() { + var url = window.location.href; + if (url.indexOf("/circ/circulation.pl?borrowernumber=") !== -1) + return "circ"; + else if (url.indexOf("/members/moremember.pl?borrowernumber=") !== -1) + return "borrower"; + + return null; +} + /** * Returns a roughly ideal position to scroll an element into view * @param {string} target - The HTML id of the element to scroll into view -- 2.39.5