From 0ccf4831bb9f0ecf2ba67924aec4302d1a03e65b Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Wed, 30 Jul 2025 11:30:21 +0000 Subject: [PATCH] Bug 40549: Silence two warnings in patron import tool To test: 1 - Tail the logs in a terminal: tail -f /var/log/koha/kohadev/*.log 2 - Browse to Tools->IMport patrons 3 - Note warning when loading the page: Use of uninitialized value $uploadborrowers in concatenation (.) or string at /kohadevbox/koha/tools/import_borrowers.pl line 105. 4 - Upload a patron file, under: Preserve existing borrowers "If matching record is already in the borrowers table:" choose "Ignore..." 5 - Import the file 6 - Note an warning: Use of uninitialized value $update_dateexpiry in string eq at /kohadevbox/koha/tools/import_borrowers.pl line 113. 7 - Apply patch, restart all 8 - Reload the tool 9 - Note no warning 10 - Upload the file again, same settings 11 - Note no warning 12 - Sign off! Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi --- tools/import_borrowers.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/import_borrowers.pl b/tools/import_borrowers.pl index 41c40ee269c..9a703f4e813 100755 --- a/tools/import_borrowers.pl +++ b/tools/import_borrowers.pl @@ -102,14 +102,14 @@ if ($matchpoint) { my $createpatronlist = $input->param('createpatronlist') || 0; my $dt = dt_from_string(); my $timestamp = $dt->ymd('-') . ' ' . $dt->hms(':'); -my $patronlistname = $uploadborrowers . ' (' . $timestamp . ')'; if ( $op eq 'cud-import' && $uploadborrowers && length($uploadborrowers) > 0 ) { + my $patronlistname = $uploadborrowers . ' (' . $timestamp . ')'; my $handle = $input->upload('uploadborrowers'); my %defaults = $input->Vars; my $overwrite_passwords = defined $input->param('overwrite_passwords') ? 1 : 0; - my $update_dateexpiry = $input->param('update_dateexpiry'); + my $update_dateexpiry = $input->param('update_dateexpiry') // ""; my $return = $Import->import_patrons( { file => $handle, -- 2.50.1