From 6bddb3be0ef370657b26ec6c6b5848dfb35a5ac9 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Mon, 2 Nov 2020 13:48:39 +0000 Subject: [PATCH] Bug 40559: Fix noisy warning in MARCdetail Content-Type: text/plain; charset=utf-8 Rebased for 25.06. Resolves: [2025/07/31 10:59:02] [WARN] Use of uninitialized value in string eq at /usr/share/koha/catalogue/MARCdetail.pl line 203. Test plan: Check if warn disappears with this patch. Trigger the warn by opening catalogue/MARCdetail on staff view. (Should be enough with a normal MARC record.) Signed-off-by: Marcel de Rooy --- catalogue/MARCdetail.pl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/catalogue/MARCdetail.pl b/catalogue/MARCdetail.pl index b90822c059..7316b5434d 100755 --- a/catalogue/MARCdetail.pl +++ b/catalogue/MARCdetail.pl @@ -200,7 +200,9 @@ for ( my $tabloop = 0 ; $tabloop <= 10 ; $tabloop++ ) { if ( $tagslib->{ $fields[$x_i]->tag() }->{ $subf[$i][0] }->{isurl} ) { $subfield_data{marc_value} = $subf[$i][1]; $subfield_data{is_url} = 1; - } elsif ( $tagslib->{ $fields[$x_i]->tag() }->{ $subf[$i][0] }->{kohafield} eq "biblioitems.isbn" ) { + } elsif ( $tagslib->{ $fields[$x_i]->tag() }->{ $subf[$i][0] }->{kohafield} + && $tagslib->{ $fields[$x_i]->tag() }->{ $subf[$i][0] }->{kohafield} eq "biblioitems.isbn" ) + { # warn " tag : ".$tagslib->{$fields[$x_i]->tag()}." subfield :".$tagslib->{$fields[$x_i]->tag()}->{$subf[$i][0]}. "ISBN : ".$subf[$i][1]."PosttraitementISBN :".DisplayISBN($subf[$i][1]); $subfield_data{marc_value} = $subf[$i][1]; -- 2.39.5