From 2bddfcb706fcd25f68c727de14d6d8a9d907aa4e Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Tue, 5 Aug 2025 15:40:10 -0300 Subject: [PATCH] Bug 40596: Fix Identity Provider test plan for CAS and Shibboleth protocols MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The upgrade_class() test was failing because it planned 5 tests but ran 9. This happened because we added CAS and Shibboleth protocols to the protocol_to_class_mapping, increasing the number of protocols from 2 to 4. The test runs 2 tests per protocol plus 1 test for invalid protocol: - Original: 2 protocols × 2 tests + 1 = 5 tests - Current: 4 protocols × 2 tests + 1 = 9 tests Updated the test plan to reflect the correct number of tests. Test plan: 1. Apply patch 2. Run prove t/db_dependent/Koha/Auth/Identity/Provider.t 3. Verify all tests pass including upgrade_class() tests --- t/db_dependent/Koha/Auth/Identity/Provider.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/db_dependent/Koha/Auth/Identity/Provider.t b/t/db_dependent/Koha/Auth/Identity/Provider.t index c43c58dc95a..6e17b7191a3 100755 --- a/t/db_dependent/Koha/Auth/Identity/Provider.t +++ b/t/db_dependent/Koha/Auth/Identity/Provider.t @@ -188,7 +188,7 @@ subtest 'set_mapping() tests' => sub { subtest 'upgrade_class() tests' => sub { - plan tests => 5; + plan tests => 9; # 4 protocols × 2 tests + 1 invalid protocol test $schema->storage->txn_begin; -- 2.50.1