From b16af771163e073b7d5dfd69817c279e88dd835e Mon Sep 17 00:00:00 2001 From: Pedro Amorim Date: Thu, 7 Aug 2025 10:55:52 +0000 Subject: [PATCH] Bug 40517: (QA follow-up): Fix 'group selected' button active with just 1 hold selected This fixes the following bug: 1) Select 1 hold, notice the 'group selected' button is still disabled 2) Select a 2nd hold, notice the 'group selected' button becomes enabled 3) Unselect one of the holds, notice the 'group select' is kept enabled (this is wrong, it should become disabled) --- koha-tmpl/intranet-tmpl/prog/js/holds.js | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/holds.js b/koha-tmpl/intranet-tmpl/prog/js/holds.js index bed19e2c90f..f5144804db7 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/holds.js +++ b/koha-tmpl/intranet-tmpl/prog/js/holds.js @@ -795,17 +795,18 @@ $(document).ready(function () { $(".holds_table .select_hold:checked").length ); if (patron_page) { - if ($(".holds_table .select_hold:checked").length == 0) { - $(".cancel_selected_holds").prop("disabled", true); - $(".suspend_selected_holds").prop("disabled", true); - $(".group_selected_holds").prop("disabled", true); - } else { - if ($(".holds_table .select_hold:checked").length >= 2) { - $(".group_selected_holds").prop("disabled", false); - } - $(".suspend_selected_holds").prop("disabled", false); - $(".cancel_selected_holds").prop("disabled", false); - } + var selectedHolds = $(".holds_table .select_hold:checked"); + var hasSelectedHolds = selectedHolds.length > 0; + var hasMultipleSelectedHolds = selectedHolds.length >= 2; + + $(".cancel_selected_holds, .suspend_selected_holds").prop( + "disabled", + !hasSelectedHolds + ); + $(".group_selected_holds").prop( + "disabled", + !hasMultipleSelectedHolds + ); } } -- 2.39.5