From 203421a0feee6a5893eafe9d343d0eda84fa846d Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Fri, 8 Aug 2025 15:33:42 +0000 Subject: [PATCH] Bug 40625: Fix duplicate cashup records via POST/REDIRECT/GET pattern The cashup functionality on both /pos/register.pl and /pos/registers.pl pages was using GET requests via anchor tags, which could cause duplicate cashup records when users refreshed the page after performing a cashup. This patch implements proper POST/REDIRECT/GET pattern with CSRF protection: 1. Convert anchor tag buttons to proper HTML forms with submit buttons 2. Add CSRF token protection to all cashup operations 3. Change operation from 'cashup' to 'cud-cashup' for CSRF compliance 4. Implement redirects after successful cashup operations to prevent resubmission 5. Update JavaScript to populate form fields instead of href attributes This ensures cashup operations follow HTTP semantics properly (POST for state changes) and prevents duplicate submissions while maintaining the existing user experience. Test plan: 1. Apply patch and restart services 2. Go to Point of Sale > Cash registers 3. Click "Record cashup" on any register - should open modal 4. Click "Confirm" - should perform cashup and reload page 5. Refresh the page - should NOT create duplicate cashup record 6. Go to Point of Sale > Register for individual register 7. Click "Record cashup" - should open modal 8. Click "Confirm" - should perform cashup and reload page 9. Refresh the page - should NOT create duplicate cashup record 10. On registers page, try "Cashup all" button - should work correctly 11. Verify all existing functionality (modals, summaries) still works 12. Check browser developer tools - all requests should be POST for cashup operations --- .../prog/en/modules/pos/register.tt | 37 ++++---- .../prog/en/modules/pos/registers.tt | 87 ++++++++++--------- pos/register.pl | 6 +- pos/registers.pl | 6 +- 4 files changed, 80 insertions(+), 56 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt index 7e70e2c62d7..e01152f7515 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt @@ -366,23 +366,30 @@