From e81baf19426601740311cbc88c535d3b52afec18 Mon Sep 17 00:00:00 2001 From: Hammat Wele Date: Thu, 24 Jul 2025 19:40:00 +0000 Subject: [PATCH] Bug 34631: (follow-up) Non-superlibrarians should not have the right to select the library --- .../prog/en/modules/admin/preferences/admin.pref | 2 +- tools/additional-contents.pl | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref index f618eb468a9..5310ecc3c99 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref @@ -149,7 +149,7 @@ Administration: 1: "Yes" 0: "No" - - - "Prevent staff (but not superlibrarians) from editing Additional contents in other libraries: " + - "Prevent staff (but not superlibrarians) from editing additional contents for other libraries: " - pref: IndependentBranchesAdditionalcontents default: 0 choices: diff --git a/tools/additional-contents.pl b/tools/additional-contents.pl index 37ac107f04f..25d3b730603 100755 --- a/tools/additional-contents.pl +++ b/tools/additional-contents.pl @@ -71,10 +71,10 @@ my $my_branch_as_staff = if ( $op eq 'add_form' ) { my $additional_content = Koha::AdditionalContents->find($id); - $additional_content = - undef $my_branch_as_staff + $additional_content = undef + if ( $my_branch_as_staff && $additional_content - && C4::Context->userenv()->{'branch'} ne $additional_content->branchcode; + && C4::Context->userenv()->{'branch'} ne $additional_content->branchcode ); my $translated_contents; if ($additional_content) { $translated_contents = { map { $_->lang => $_ } $additional_content->translated_contents->as_list }; -- 2.34.1