From d3abbb76b04a41c40d44ff9661ee5c911e968bfa Mon Sep 17 00:00:00 2001 From: Paul Derscheid Date: Fri, 15 Aug 2025 15:28:51 +0000 Subject: [PATCH] Bug 40656: (follow-up) Correct inverted logic for column visibility --- koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt | 4 ++-- koha-tmpl/intranet-tmpl/prog/js/additional-filters.js | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt index 16373710754..56584307bbc 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt @@ -211,12 +211,12 @@ ); const additional_filters = AdditionalFilters.init(["filter-expired", "filter-cancelled"]) - .onChange((filters, { anyFiltersApplied }) => { + .onChange((filters, { anyFiltersNotApplied }) => { bookings_table.DataTable().ajax.reload(() => { bookings_table .DataTable() .column("status:name") - .visible(anyFiltersApplied, false); + .visible(anyFiltersNotApplied, false); }); }) .build({ diff --git a/koha-tmpl/intranet-tmpl/prog/js/additional-filters.js b/koha-tmpl/intranet-tmpl/prog/js/additional-filters.js index bcb5fc926ad..550e7bb74c4 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/additional-filters.js +++ b/koha-tmpl/intranet-tmpl/prog/js/additional-filters.js @@ -16,8 +16,9 @@ * JavaScript Usage: * @example * const additional_filters = AdditionalFilters.init(['filter-expired', 'filter-cancelled']) - * .onChange((filters, { anyFiltersApplied }) => { - * table.column('status').visible(anyFiltersApplied); + * .onChange((filters, { anyFiltersNotApplied }) => { + * // Show status column when any filters are showing additional items + * table.column('status').visible(anyFiltersNotApplied); * }) * .build({ * status: ({ filters, isNotApplied }) => -- 2.39.5