From 759c219289a575c3f4c5902d298c8f6597b403ab Mon Sep 17 00:00:00 2001 From: Pedro Amorim Date: Thu, 21 Aug 2025 08:23:48 +0000 Subject: [PATCH] Bug 39345: (QA follow-up): Fix QA complaints QA script still fails but I believe these are false positives caused by the tests files being moved Signed-off-by: Eric Phetteplace --- Koha/ERM/EUsage/COUNTER/5_1.pm | 2 +- t/db_dependent/Koha/ERM/EUsage/COUNTER_5.1/CounterFile.t | 4 ++-- t/db_dependent/Koha/ERM/EUsage/COUNTER_5.1/SushiCounter.t | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Koha/ERM/EUsage/COUNTER/5_1.pm b/Koha/ERM/EUsage/COUNTER/5_1.pm index 39842d0c2e..62e0038e12 100644 --- a/Koha/ERM/EUsage/COUNTER/5_1.pm +++ b/Koha/ERM/EUsage/COUNTER/5_1.pm @@ -104,7 +104,7 @@ sub get_counter51_value { } } -=head3 _get_SUSHI_Name_Value +=head3 get_mapped_SUSHI_values Given a SUSHI response, get the value for the given key in the correct format for the COUNTER report https://counter5.cambridge.org/r51/sushi-docs/ diff --git a/t/db_dependent/Koha/ERM/EUsage/COUNTER_5.1/CounterFile.t b/t/db_dependent/Koha/ERM/EUsage/COUNTER_5.1/CounterFile.t index 05a603bbdf..b7e8ccb1b0 100755 --- a/t/db_dependent/Koha/ERM/EUsage/COUNTER_5.1/CounterFile.t +++ b/t/db_dependent/Koha/ERM/EUsage/COUNTER_5.1/CounterFile.t @@ -17,8 +17,8 @@ use Modern::Perl; -# use Test::NoWarnings; -use Test::More tests => 2; +use Test::NoWarnings; +use Test::More tests => 3; use Koha::Database; use Koha::ERM::EUsage::CounterFile; diff --git a/t/db_dependent/Koha/ERM/EUsage/COUNTER_5.1/SushiCounter.t b/t/db_dependent/Koha/ERM/EUsage/COUNTER_5.1/SushiCounter.t index da8beca595..cdfa7d1cf5 100755 --- a/t/db_dependent/Koha/ERM/EUsage/COUNTER_5.1/SushiCounter.t +++ b/t/db_dependent/Koha/ERM/EUsage/COUNTER_5.1/SushiCounter.t @@ -17,8 +17,8 @@ use Modern::Perl; -# use Test::NoWarnings; -use Test::More tests => 18; +use Test::NoWarnings; +use Test::More tests => 19; use Koha::ERM::EUsage::SushiCounter; use Koha::Database; -- 2.51.0