From 5ca06b2812614e3a61cd7e9175e7b80da6275a96 Mon Sep 17 00:00:00 2001 From: Pedro Amorim Date: Thu, 21 Aug 2025 08:21:11 +0000 Subject: [PATCH] Bug 39345: (QA follow-up): Fix data provider tests Update original tests to consider COUNTER 5 specifically. Add new test for COUNTER 5.1. Signed-off-by: Eric Phetteplace Signed-off-by: Nick Clemens --- .../Koha/ERM/EUsage/UsageDataProvider.t | 41 +++++++++++++++++-- 1 file changed, 37 insertions(+), 4 deletions(-) diff --git a/t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t b/t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t index 7bee25b881e..b95c50d5ef1 100755 --- a/t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t +++ b/t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t @@ -32,7 +32,7 @@ my $builder = t::lib::TestBuilder->new; subtest '_build_url_query' => sub { - plan tests => 2; + plan tests => 3; $schema->storage->txn_begin; @@ -47,7 +47,7 @@ subtest '_build_url_query' => sub { class => 'Koha::ERM::EUsage::UsageDataProviders', value => { service_url => $service_url, api_key => $api_key, requestor_id => $requestor_id, - customer_id => $customer_id, name => $name, service_platform => undef + customer_id => $customer_id, name => $name, service_platform => undef, report_release => 5 } } ); @@ -79,8 +79,8 @@ subtest '_build_url_query' => sub { { class => 'Koha::ERM::EUsage::UsageDataProviders', value => { - service_url => $service_url, api_key => $api_key, requestor_id => $requestor_id, - customer_id => $customer_id, name => $name, service_platform => $test_platform + service_url => $service_url, api_key => $api_key, requestor_id => $requestor_id, + customer_id => $customer_id, name => $name, service_platform => $test_platform, report_release => 5 } } ); @@ -108,6 +108,39 @@ subtest '_build_url_query' => sub { . $test_platform ); + my $usage_data_provider_51 = $builder->build_object( + { + class => 'Koha::ERM::EUsage::UsageDataProviders', + value => { + service_url => $service_url, api_key => $api_key, requestor_id => $requestor_id, + customer_id => $customer_id, name => $name, service_platform => $test_platform, report_release => '5.1' + } + } + ); + + $usage_data_provider_51->{report_type} = 'TR_J1'; + $usage_data_provider_51->{begin_date} = '2023-08-01'; + $usage_data_provider_51->{end_date} = '2023-09-30'; + + is( + $usage_data_provider_51->_build_url_query, + $service_url + . '/r51/reports/' + . lc( $usage_data_provider->{report_type} ) + . '?customer_id=' + . $customer_id + . '&requestor_id=' + . $requestor_id + . '&api_key=' + . $api_key + . '&begin_date=' + . substr( $usage_data_provider->{begin_date}, 0, 7 ) + . '&end_date=' + . substr( $usage_data_provider->{end_date}, 0, 7 ) + . '&platform=' + . $test_platform + ); + $schema->storage->txn_rollback; }; -- 2.39.5