From 94e12f5d122e806881de58754320d04242cc6760 Mon Sep 17 00:00:00 2001 From: Lisette Scheer Date: Tue, 2 Sep 2025 15:32:02 +0000 Subject: [PATCH] Bug 40740: Validation for biblioitems in about/system information joins on biblionumber not biblioitemnumber This patche fixes the validation for biblioitems to only warn when the biblioitemnumber is in both tables instead of the biblionumber. To test: 1. Delete an item that has another item on the record. 2. Go to About and select the system configuration tab 3. Observe there is a warning. 4. Run a report select bi.biblioitemnumber, dbi.biblioitemnumber from biblioitems bi join deletedbiblioitems dbi on bi.biblionumber=dbi.biblionumber 5. You'll see the numbers don't match 6. Apply the patch 7. Repeat step 2 8. Observe no warning 9. Repeat step 4 10. Observe no results. 11. Sign off! --- about.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/about.pl b/about.pl index 788ad2f112c..2f35de99883 100755 --- a/about.pl +++ b/about.pl @@ -458,7 +458,7 @@ if ( $tab eq 'sysinfo' ) { { Slice => {} } ); my $biblioitems = $dbh->selectall_arrayref( - q|select bi.biblioitemnumber from biblioitems bi join deletedbiblioitems dbi on bi.biblionumber=dbi.biblionumber|, + q|select bi.biblioitemnumber from biblioitems bi join deletedbiblioitems dbi on bi.biblioitemnumber=dbi.biblioitemnumber|, { Slice => {} } ); my $items = $dbh->selectall_arrayref( -- 2.39.5