From 33815731425a3acb6a932e248dea87ac25039df1 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 4 Sep 2025 11:14:35 +0200 Subject: [PATCH] Bug 40453: Do not rely on hardcoded index Signed-off-by: Jonathan Druart --- .../prog/en/modules/admin/localization.tt | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt index 67ab0b4c603..fd60bb4987f 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt @@ -103,8 +103,8 @@ Id Entity Code - Language - Translation + Language + Translation   @@ -296,6 +296,9 @@ } }); + const th_lang_index = document.querySelector('th.lang').cellIndex; + const th_translation_index = document.querySelector('th.translation').cellIndex; + $("#add_translation").on('submit', function(e){ e.preventDefault(); let localization = { @@ -312,9 +315,8 @@ } else { var new_row = table_dt.row.add( [ success.id, success.entity, success.code, success.lang, success.translation, " Delete" ] ).draw().node(); $( new_row ).attr("id", "row_id_" + success.id ).data("id", success.id ); - /* Is there a better way to target contenteditable cells than by index? */ - $( new_row.children[3] ).prop("contenteditable", true).addClass("lang") - $( new_row.children[4] ).prop("contenteditable", true).addClass("translation") + $( new_row.children[th_lang_index] ).prop("contenteditable", true).addClass("lang") + $( new_row.children[th_translation_index] ).prop("contenteditable", true).addClass("translation") show_message({ type: 'success_on_insert', data: success }); } }, -- 2.34.1