From 68b6ab2285af6d7965c91e45f1e14fe99bb8a5d3 Mon Sep 17 00:00:00 2001 From: Emily Lamancusa Date: Thu, 4 Sep 2025 09:37:37 -0400 Subject: [PATCH] Bug 40755: Fix typo in waiting_holds.inc Fix a typo that caused an error 500 on the holds awaiting pickup page when there are holds with cancellation requests. To test: 1. Enable hold cancellation requests from the OPAC i. Go to Administration > Circulation and Fines rules ii. In the "Default waiting hold cancellation policy" section, add the rule: All / All / Yes 2. Place at least two holds for pickup at the logged-in library (for ease of testing, place both holds for the same patron) 3. Check in items for both holds and confirm to set holds to Waiting 4. Log into the OPAC as the patron from step 2 5. Go to the patron's holds tab and request cancellation for both holds 6. In the staff interface, go to Circulation > Holds awaiting pickup ==> Error 500! :( 7. Apply patch and refresh the page ==> The page loads! :) Bonus testing (KTD only): 1. Edit one of the cancellation request dates, so that they are not both the same date: ktd --shell koha-mysql kohadev SELECT * FROM hold_cancellation_requests; UPDATE hold_cancellation_requests SET creation_date= WHERE hold_cancellation_request_id = ; 2. Refresh the Holds awaiting pickup page again, and switch to the Holds with cancellation requests tab 3. Sort by hold cancellation request date and confirm the sorting works correctly Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart --- koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc index 97a9a72fcf7..2ba57981f4f 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc @@ -30,7 +30,7 @@ [% reserveloo.reservedate | $KohaDates %] [% IF table_name == 'holdscr' %] [% IF reserveloo.cancellation_requests.count %] - + [% FOREACH cancellation_request IN reserveloo.cancellation_requests %] [% cancellation_request.creation_date | $KohaDates %] [% END %] -- 2.34.1