From b1ebd465bf936dfc228cac74826abffd4ee1d102 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 4 Sep 2025 11:54:59 +0200 Subject: [PATCH] Bug 40663: Revert "Bug 40490: Remove warnings from GD::Barcode::QRcode - U24" This reverts commit fd6ceb6b244bf65d8cf0c1144a9a903490fdaadf. Signed-off-by: Tomas Cohen Arazi --- t/db_dependent/api/v1/two_factor_auth.t | 28 ++----------------------- 1 file changed, 2 insertions(+), 26 deletions(-) diff --git a/t/db_dependent/api/v1/two_factor_auth.t b/t/db_dependent/api/v1/two_factor_auth.t index 175e6e9529d..ddb9178e3a2 100755 --- a/t/db_dependent/api/v1/two_factor_auth.t +++ b/t/db_dependent/api/v1/two_factor_auth.t @@ -90,19 +90,7 @@ subtest 'registration and verification' => sub { $tx = $t->ua->build_tx( POST => "/api/v1/auth/two-factor/registration" ); $tx->req->cookies( { name => 'CGISESSID', value => $session->id } ); $tx->req->env( { REMOTE_ADDR => $remote_address } ); - { - # Ignore the following warning - # Use of uninitialized value $aMask[1383] in bitwise xor (^) at /usr/local/share/perl/5.36.0/GD/Barcode/QRcode.pm line 217. - # We do not want to expect it (using Test::Warn): it is a bug from GD::Barcode - local $SIG{__WARN__} = sub { }; - my $dup_err; - local *STDERR; - open STDERR, ">>", \$dup_err; - - $t->request_ok($tx)->status_is(201); - - close STDERR; - } + $t->request_ok($tx)->status_is(201); my $secret32 = $t->tx->res->json->{secret32}; $tx = $t->ua->build_tx( POST => "/api/v1/auth/two-factor/registration/verification" ); @@ -132,19 +120,7 @@ subtest 'registration and verification' => sub { $tx = $t->ua->build_tx( POST => "/api/v1/auth/two-factor/registration" ); $tx->req->cookies( { name => 'CGISESSID', value => $session->id } ); $tx->req->env( { REMOTE_ADDR => $remote_address } ); - { - # Ignore the following warning - # Use of uninitialized value $aMask[1383] in bitwise xor (^) at /usr/local/share/perl/5.36.0/GD/Barcode/QRcode.pm line 217. - # We do not want to expect it (using Test::Warn): it is a bug from GD::Barcode - local $SIG{__WARN__} = sub { }; - my $dup_err; - local *STDERR; - open STDERR, ">>", \$dup_err; - - $t->request_ok($tx)->status_is(201); - - close STDERR; - } + $t->request_ok($tx)->status_is(201); $secret32 = $t->tx->res->json->{secret32}; $auth = Koha::Auth::TwoFactorAuth->new( { patron => $patron, secret32 => $secret32 } ); -- 2.51.0