From 88355c9cd241004bdd0b0f2a7994667b3e9e039f Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 9 Sep 2025 11:45:21 +0200 Subject: [PATCH] Bug 30515: Use print if the patron's preference is empty If the patron has not selected a transport type we still want to print. ie. the patrons cannot totally opt out. --- misc/cronjobs/overdue_notices.pl | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl index ea5d9e57f83..d5672a1f329 100755 --- a/misc/cronjobs/overdue_notices.pl +++ b/misc/cronjobs/overdue_notices.pl @@ -755,14 +755,23 @@ END_SQL if ( $patronpref && $patronpref->{'transports'} ) { @message_transport_types = keys %{ $patronpref->{'transports'} }; } - } else { - my @message_transport_types = - @{ GetOverdueMessageTransportTypes( $branchcode, $overdue_rules->{categorycode}, $i ) }; - @message_transport_types = - @{ GetOverdueMessageTransportTypes( q{}, $overdue_rules->{categorycode}, $i ) } - unless @message_transport_types; } + use Data::Printer colored => 1; + warn p @message_transport_types; + @message_transport_types = + @{ GetOverdueMessageTransportTypes( $branchcode, $overdue_rules->{categorycode}, $i ) } + unless @message_transport_types; + + use Data::Printer colored => 1; + warn p @message_transport_types; + @message_transport_types = + @{ GetOverdueMessageTransportTypes( q{}, $overdue_rules->{categorycode}, $i ) } + unless @message_transport_types; + + use Data::Printer colored => 1; + warn p @message_transport_types; + my $print_sent = 0; # A print notice is not yet sent for this patron for my $mtt (@message_transport_types) { next if $mtt eq 'itiva'; -- 2.34.1