From 5a7bbc758f0b2d6ec585525cb529d0fcdf2ec622 Mon Sep 17 00:00:00 2001 From: Hammat Wele Date: Wed, 17 Sep 2025 12:38:18 +0000 Subject: [PATCH] Bug 40799: Loading spinner not removed because .cover-slider is now used instead of .cover-slides After Bug 32642, the spinner on cover images is hidden by verify_cover_images() which removes the .cover-slides class from the cover container. However, Bug 33848 modified the SCSS so that the spinner is now triggered by .cover-slider instead of .cover-slides. As a result, the spinner is never removed, because verify_cover_images() only removes .cover-slides. Test plan 1- Follow the test plan from Bug 32642. ==> The spinner is displayed and never disappears. 2- Apply the patch 3- Reload the page. ==> The spinner disappears once the cover image is loaded. --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt index 086a42e6864..f3afd628921 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ -1734,7 +1734,7 @@ $(coverSlide).find("img").each( function() { if( !this.complete || this.naturalHeight == 0 ) check_complete = 0; }); - if( check_complete ) $(coverSlide).removeClass('cover-slides'); + if( check_complete ) $(coverSlide).css('background-image', 'none'); } }); -- 2.34.1