From 4b7830dc34130b7cb936801bba2d1fbbfbbe84d2 Mon Sep 17 00:00:00 2001 From: Laura_Escamilla Date: Thu, 18 Sep 2025 16:24:38 +0000 Subject: [PATCH] Bug 35612: Added the system preference within the Circulation and Fines policy in Administration MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit To test:
 1. Set system preferences: * FinesMode: Calculate and Charge * AccountLinesBranchSource: (this will be tested with different values later) 2. Set circulation rules: * Ensure a circulation rule exists that charges overdue fines for the item type and branch you're testing with. 3. Check out an item to a test patron with a due date in the past (to trigger overdue). 4. Run the fines cronjob: perl /usr/share/koha/bin/cronjobs/fines.pl 5. Verify fines appear on the patron’s Accounting tab in the staff interface. 6. Confirm branchcode is NULL in the database: * SELECT accountlines_id, branchcode, debit_type_code FROM accountlines ORDER BY accountlines_id DESC LIMIT 10; * Expect to see branchcode = NULL for the OVERDUE debit. 7. Apply the patch to your Koha instance. 8. Run updatedatabase 9. Run restart_all 10. In the staff interface, go to Administration → System Preferences, search for AccountLinesBranchSource, and set it to: "the library the item was checked out from" (checkoutbranch) 11. Repeat steps 3–6. 12. Confirm that in the SQL output, the branchcode now matches the checkout branch of the item. 13. Repeat steps 10–12 with each of the following AccountLinesBranchSource values: * itemhomebranch: The item’s home library * patronhomebranch: The patron’s home library * checkoutbranch: The checkout library (already tested) * none: Should result in NULL branchcode * Confirm that: The correct branch is recorded in the branchcode field of accountlines. When set to none, branchcode is again NULL. --- .../prog/en/modules/admin/preferences/circulation.pref | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref index 82070552d6..9326801268 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref @@ -1153,6 +1153,16 @@ Circulation: 0: allow - renewing of items from the staff interface and via the misc/cronjobs/automatic_renewals.pl cronjob. Fines policy: + - + - pref: AccountLinesBranchSource + type: choice + default: none + choices: + itemhomebranch: "the item's home library" + patronhomebranch: "the patron's home library" + checkoutbranch: "the library the item was checked out from" + none: "do not populate the branchcode" + - determines which branchcode is recorded in the accountlines table. - - pref: finesCalendar type: choice -- 2.39.5