From 2f990d06147d14e86296634f2cb5d88f70563625 Mon Sep 17 00:00:00 2001 From: Chloe Zermatten Date: Mon, 15 Sep 2025 10:05:19 +0000 Subject: [PATCH] Bug 40807: fix: username field in quick add form The username field would not appear in the quick add form despite being marked as required in BorrowerMandatoryField. This was due the interaction between a change introduced by Bug 38459 and the dummy input for the username field. This patch moves the dummy input so that the true input is the last child that the change in Bug 38459 targets. This allows the username field to appear when added to BorrowerMandatoryField. Test plan: 0. (Before applying the patch, follow the replication tests as in the comment above.) 1. Login to the Koha staff interface 2. Search system preferences for BorrowerMandatoryField 3. Toggle on Username (userid) so it is added to the list of fields and save your changes. 4. Navigate to /cgi-bin/koha/members/memberentry.pl?op=add_form&categorycode=PT, notice that username still shows and is marked as required 5. Navigate to /cgi-bin/koha/members/memberentry.pl?op=add_form&categorycode=PT&quickadd=true, notice that the username field does show. Signed-off-by: Brendan Lawlor --- .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt index a4cee866f3..fc6f59d4fb 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt @@ -1162,6 +1162,9 @@
  • + [%# Dummy input to avoid Firefox from using userid/password saved for authentication %] + + [% IF ( NoUpdateLogin ) %] [% IF ( op == 'duplicate' ) %] @@ -1176,9 +1179,6 @@ [% END %] [% END # /IF ( NoUpdateLogin ) %] - [%# Dummy input to avoid Firefox from using userid/password saved for authentication %] - - [% IF ( mandatoryuserid ) %] Required [% END %] -- 2.39.5