From 9495b2f3f56fe28abcd5cebacb68d0c1fca5bc08 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1s=20Cohen=20Arazi?= Date: Fri, 19 Sep 2025 08:27:00 -0300 Subject: [PATCH] Bug 39190: (follow-up) Two QA fixes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch: * Removes unused logger object instantiation * Adds missing Test::NoWarnings to the API tests Signed-off-by: Tomás Cohen Arazi --- Koha/File/Transport/SFTP.pm | 2 -- t/db_dependent/api/v1/file_transports.t | 3 ++- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/Koha/File/Transport/SFTP.pm b/Koha/File/Transport/SFTP.pm index 73755f22c3..936472b801 100644 --- a/Koha/File/Transport/SFTP.pm +++ b/Koha/File/Transport/SFTP.pm @@ -90,8 +90,6 @@ sub upload_file { my ( $self, $local_file, $remote_file ) = @_; my $operation = "upload"; - my $logger = Koha::Logger->get_logger(); - $self->{connection}->put( $local_file, $remote_file ) or return $self->_abort_operation($operation); $self->add_message( diff --git a/t/db_dependent/api/v1/file_transports.t b/t/db_dependent/api/v1/file_transports.t index ebe3a56cfa..c1f492f2e7 100755 --- a/t/db_dependent/api/v1/file_transports.t +++ b/t/db_dependent/api/v1/file_transports.t @@ -17,8 +17,9 @@ use Modern::Perl; -use Test::More tests => 5; +use Test::More tests => 6; use Test::Mojo; +use Test::NoWarnings; use t::lib::TestBuilder; use t::lib::Mocks; -- 2.51.0