From 82bb9d7d1d705e789eab499ccb84b067578016ca Mon Sep 17 00:00:00 2001 From: Pedro Amorim Date: Thu, 29 May 2025 11:49:29 +0000 Subject: [PATCH] Bug 40024: Update requested_partners check MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Test plan, k-t-d, don't apply patch: 1) Enable ILLModule 2) Install a backend that does not provide the 'get_requested_partners' capability, e.g. the libkey lending tool (IncDocs) backend plugin: https://github.com/openfifth/koha-ill-libkey-lending-tool/releases/tag/v2.0.3 3) Restart plack $ koha-plack --restart kohadev 4) Create a new IncDocs ILL request: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=IncDocs 5) Add a DOI '123', a cardnumber '42' and any library. Click 'Make request'. 6) You should now be on the 'Manage request' page. Notice there's a '(0)' after the status 'New request'. This happens because '_backend_capability' method returns '0' if the backend does not implement the capability. The template checks for 'length', and length of '0' is '1'. 7) Apply patch. Refresh the 'Manage request' page. Notice the '(0)' is no longer shown. Additional testing, ensure no regression is added: 1) Edit the only ILL partner present in k-t-d: /cgi-bin/koha/members/memberentry.pl?op=edit_form&destination=circ&borrowernumber=16 2) Add a 'primary email'. Click 'Save'. 3) Do the same but for a Standard request: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 4) Add a type, a cardnumber '42' and any library. Click 'Make request'. 5) You should now be on the 'Manage request' page. Click 'Place request with partners'. Select the only one available 'FRL - Walker' and click 'Send email'. 6) Notice the status shows 'Requested from partners ( Signed-off-by: Tomás Cohen Arazi --- koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt index 1d8957641e..b3ee07a1ca 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt @@ -651,7 +651,7 @@ [% request.statusalias.lib | html %] [% ELSE %] [% request.capabilities.$req_status.name | html %] - [% IF request.requested_partners.length > 0 %] + [% IF request.requested_partners %] ([% request.requested_partners | html %]) [% END %] [% END %] -- 2.51.0