From f6468221cf9456e9d4ce78bc0072b125f5cdd898 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Tue, 22 Jul 2025 14:52:16 +0200 Subject: [PATCH] Bug 30915: Remove Context.Scalar calls from templates Test plan: git grep on "Context.Scalar" Go to book with holdable items in staff catalogue detail. Check if Place hold is seen in the horizontal toolbar above the title. Place an article request with a patron. Check the article requests tab on patron detail. Same for the article requests tab on moremember (Patron details). Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart --- koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc | 4 +--- koha-tmpl/intranet-tmpl/prog/en/includes/catalog-strings.inc | 5 ++--- .../prog/en/includes/patron-article-requests.inc | 3 +-- .../intranet-tmpl/prog/en/includes/patron-detail-tabs.inc | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 1 - .../intranet-tmpl/prog/en/modules/circ/request-article.tt | 3 +-- .../intranet-tmpl/prog/en/modules/members/moremember.tt | 1 - 7 files changed, 6 insertions(+), 13 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc index 454dd266c20..7b4ac6920fb 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc @@ -1,4 +1,3 @@ -[% USE Context %] [% USE Biblio %] [%# Parameters: %] @@ -259,8 +258,7 @@ > [% IF ( CAN_user_reserveforothers ) %] - [% SET items = biblio.items %] - [% IF Context.Scalar(Context.Scalar(items, "filter_by_for_hold"), "count") %] + [% IF biblio.items.filter_by_for_hold.count %] [% IF ( holdfor ) %]