From a15d7d0c925249359bd1cf98a542e8e42a416489 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Wed, 5 Jun 2013 10:01:17 -0400 Subject: [PATCH] Bug 10382 - collection not returning to null when removed from course reserves Test Plan: 1) Create an item, do not set a collection code 2) Add the item to a course, and choose to set a collection code 3) Ensure the course is enabled, and the collection code is now visible 4) Disable the course, ensure the collection code is no longer visible --- C4/CourseReserves.pm | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/C4/CourseReserves.pm b/C4/CourseReserves.pm index c3e25e6..e1583dd 100644 --- a/C4/CourseReserves.pm +++ b/C4/CourseReserves.pm @@ -605,7 +605,7 @@ sub _ModStoredFields { my ( @fields_to_update, @values_to_update ); foreach (@FIELDS) { - if ( $params{$_} ) { + if ( defined($params{$_}) ) { push( @fields_to_update, $_ ); push( @values_to_update, $params{$_} ); } @@ -671,9 +671,9 @@ sub _SwapAllFields { my %course_item_fields; my %item_fields; foreach (@FIELDS) { - if ( $course_item->{$_} ) { + if ( defined( $course_item->{$_} ) ) { $course_item_fields{$_} = $course_item->{$_}; - $item_fields{$_} = $item->{$_}; + $item_fields{$_} = $item->{$_} || q{}; } } -- 1.7.2.5