Bugzilla – Attachment 18674 Details for
Bug 10382
collection and location not returning to null when removed from course reserves
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10382 - collection not returning to null when removed from course reserves
Bug-10382---collection-not-returning-to-null-when-.patch (text/plain), 1.42 KB, created by
Kyle M Hall
on 2013-06-05 14:03:40 UTC
(
hide
)
Description:
Bug 10382 - collection not returning to null when removed from course reserves
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2013-06-05 14:03:40 UTC
Size:
1.42 KB
patch
obsolete
>From a15d7d0c925249359bd1cf98a542e8e42a416489 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 5 Jun 2013 10:01:17 -0400 >Subject: [PATCH] Bug 10382 - collection not returning to null when removed from course reserves > >Test Plan: >1) Create an item, do not set a collection code >2) Add the item to a course, and choose to set a collection code >3) Ensure the course is enabled, and the collection code is now visible >4) Disable the course, ensure the collection code is no longer visible >--- > C4/CourseReserves.pm | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/C4/CourseReserves.pm b/C4/CourseReserves.pm >index c3e25e6..e1583dd 100644 >--- a/C4/CourseReserves.pm >+++ b/C4/CourseReserves.pm >@@ -605,7 +605,7 @@ sub _ModStoredFields { > my ( @fields_to_update, @values_to_update ); > > foreach (@FIELDS) { >- if ( $params{$_} ) { >+ if ( defined($params{$_}) ) { > push( @fields_to_update, $_ ); > push( @values_to_update, $params{$_} ); > } >@@ -671,9 +671,9 @@ sub _SwapAllFields { > my %course_item_fields; > my %item_fields; > foreach (@FIELDS) { >- if ( $course_item->{$_} ) { >+ if ( defined( $course_item->{$_} ) ) { > $course_item_fields{$_} = $course_item->{$_}; >- $item_fields{$_} = $item->{$_}; >+ $item_fields{$_} = $item->{$_} || q{}; > } > } > >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10382
:
18674
|
19611
|
60947
|
60948
|
60979
|
61814
|
61815
|
61816
|
63531
|
72022
|
79030
|
79031
|
79032
|
79114
|
79115
|
79116
|
79207
|
79208
|
79209
|
79722
|
79723
|
79724
|
80007
|
80008
|
80009