From 0422aa0f28da5b5e09f1946f31e53dbfe3c32f65 Mon Sep 17 00:00:00 2001 From: Pedro Amorim Date: Tue, 23 Sep 2025 13:49:26 +0000 Subject: [PATCH] Bug 40529: (QA follow-up) Rebase and fix tests This further rebases on top of 40058 which removed RevertWaitingStatus. It also fixes a warning where 'eq was being utilized on initialized' coming from sub remove_as_hold_group_target Signed-off-by: Andrew Fuerste Henry --- Koha/Hold.pm | 1 + t/db_dependent/Koha/Hold.t | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Koha/Hold.pm b/Koha/Hold.pm index 9e2919fa1ed..d8e5fe236d7 100644 --- a/Koha/Hold.pm +++ b/Koha/Hold.pm @@ -303,6 +303,7 @@ sub remove_as_hold_group_target { my ($self) = @_; if ( $self->hold_group + && $self->hold_group->target_hold_id && $self->hold_group->target_hold_id eq $self->reserve_id && C4::Context->preference("DisplayAddHoldGroups") ) { diff --git a/t/db_dependent/Koha/Hold.t b/t/db_dependent/Koha/Hold.t index e7e571f1472..c2cb3dec561 100755 --- a/t/db_dependent/Koha/Hold.t +++ b/t/db_dependent/Koha/Hold.t @@ -36,7 +36,7 @@ use Koha::DateUtils qw(dt_from_string); use Koha::Holds; use Koha::Libraries; use Koha::Old::Holds; -use C4::Reserves qw( AddReserve ModReserveAffect RevertWaitingStatus); +use C4::Reserves qw( AddReserve ModReserveAffect ); use C4::Circulation qw( AddReturn ); my $schema = Koha::Database->new->schema; @@ -2078,7 +2078,7 @@ subtest '_Findgroupreserve in the context of hold groups' => sub { is( $hold->is_hold_group_target, 1, 'First hold is the hold group target' ); - C4::Reserves::RevertWaitingStatus( { itemnumber => $item->itemnumber } ); + $hold->revert_found( { itemnumber => $item->itemnumber } ); is( $hold->is_hold_group_target, 0, 'First hold is no longer the hold group target' ); is( $hold->hold_group->target_hold_id, undef, 'Hold group no longer has a target' ); -- 2.39.5