From dfc668b4cb667b77605481523d82900c3e8cad58 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1s=20Cohen=20Arazi?= Date: Fri, 26 Sep 2025 15:45:14 -0300 Subject: [PATCH] Bug 20638: (follow-up) Silence viewlog.pl warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch fixes useless warnings being printed by `viewlog.pl` I noticed while testing this new feature. To test: 1. Test the feature introduced by this patchset 2. Make sure you are running: $ ktd --shell k$ tail -f /var/log/koha/kohadev/*.log => FAIL: You see things like: ``` [2025/09/26 18:37:39] [WARN] Use of uninitialized value in substr at /kohadevbox/koha/tools/viewlog.pl line 156. [2025/09/26 18:37:39] [WARN] Use of uninitialized value in substr at /kohadevbox/koha/tools/viewlog.pl line 156. [2025/09/26 18:37:39] [WARN] Use of uninitialized value in substr at /kohadevbox/koha/tools/viewlog.pl line 156. [2025/09/26 18:37:39] [WARN] Use of uninitialized value in substr at /kohadevbox/koha/tools/viewlog.pl line 156. [2025/09/26 18:37:39] [WARN] Use of uninitialized value in substr at /kohadevbox/koha/tools/viewlog.pl line 156. [2025/09/26 18:43:44] [WARN] Use of uninitialized value in substr at /kohadevbox/koha/tools/viewlog.pl line 156. [2025/09/26 18:43:44] [WARN] Use of uninitialized value in substr at /kohadevbox/koha/tools/viewlog.pl line 156. ``` 3. Refresh the viewlog page => FAIL: They are consistent 4. Apply this patch 5. Repeat 3 => SUCCESS: No more warnings! 6. Sign off :-D Signed-off-by: Tomás Cohen Arazi --- tools/viewlog.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/viewlog.pl b/tools/viewlog.pl index 26bc8af805..770e4c47ac 100755 --- a/tools/viewlog.pl +++ b/tools/viewlog.pl @@ -153,7 +153,7 @@ if ($do_it) { $result->{'biblioitemnumber'} = q{}; $result->{'barcode'} = q{}; - if ( substr( $log->info, 0, 4 ) eq 'item' ) { + if ( defined $log->info && substr( $log->info, 0, 4 ) eq 'item' ) { # get item information so we can create a working link my $itemnumber = $log->object; -- 2.51.0