From 9459fca9da001c8c1591a180d7fc6566fee4164a Mon Sep 17 00:00:00 2001 From: Lucas Gass Date: Tue, 30 Sep 2025 19:45:19 +0000 Subject: [PATCH] Bug 40916: Fix evaluation when editing a list 1. Create a list 2. Sort this list by: title 3. Save 4. Edit the list, changing the the "Sort this list by:" to copyrightdate 5. Try to edit it again to any other type of sort. Save 6. Look again, it is reverted to copyrightdate 7. APPLY PATCH, restart_all 8. Now when you edit the list any value you use in "Sort this list by:" should be retained. --- virtualshelves/shelves.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virtualshelves/shelves.pl b/virtualshelves/shelves.pl index d52aeef6252..3753547eba2 100755 --- a/virtualshelves/shelves.pl +++ b/virtualshelves/shelves.pl @@ -125,7 +125,7 @@ if ( $op eq 'add_form' ) { my $sortfield = $query->param('sortfield'); $sortfield = 'title' unless grep { $_ eq $sortfield } qw( title author copyrightdate publicationyear itemcallnumber dateadded ); - if ( $sortfield == 'copyrightdate' and C4::Context->preference('marcflavour') == 'UNIMARC' ) { + if ( $sortfield eq 'copyrightdate' and C4::Context->preference('marcflavour') eq 'UNIMARC' ) { $sortfield = 'publicationyear'; } if ( $shelf->can_be_managed($loggedinuser) ) { -- 2.39.5