From f934c3fa9e66de64e0a3410e58225bca911e0905 Mon Sep 17 00:00:00 2001 From: CJ Lynce Date: Wed, 1 Oct 2025 18:55:51 +0000 Subject: [PATCH] Bug 33647: (follow-up) Wording update & only show lastseen if activity is tracked This follow-up implements these suggestions: A. Uses 'not recorded' instead of never when there is no date. B. Only shows lastseen if syspref TrackLastPatronActivityTriggers has at least one trigger. To test: 1. Apply patch 2. Ensure syspref TrackLastPatronActivityTriggers has no triggers set. 3. Check patron record top left corner to verify lastseen is not shown. 4. Change system TrackLastPatronActivityTriggers to trigger on Checking out an item. 5. Recheck patron record top left corner to verify lastseen says "not recorded". 6. Check out a book to patron 7. Recheck patron record top left corner to verify there is a date and time shown. --- .../prog/en/includes/circ-menu.inc | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc index f9dd3920d7..2011195ca6 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc @@ -153,14 +153,16 @@
  • Updated on: [% patron.updated_on | $KohaDates with_hours => 1 %]
  • - [% IF ( patron.lastseen ) %] -
  • - Last seen on: [% patron.lastseen | $KohaDates with_hours => 1 %] -
  • - [% ELSE %] -
  • - Last seen on: Never -
  • + [% IF Koha.Preference('TrackLastPatronActivityTriggers') %] + [% IF ( patron.lastseen ) %] +
  • + Last seen on: [% patron.lastseen | $KohaDates with_hours => 1 %] +
  • + [% ELSE %] +
  • + Last seen on: not recorded +
  • + [% END %] [% END %] [% IF patron.account_locked %] [% IF patron.login_attempts < 0 %] -- 2.39.5