From 56cf8508a458a8c6d00b1512a6ce445f7d8894c9 Mon Sep 17 00:00:00 2001 From: Matt Blenkinsop Date: Wed, 1 Oct 2025 14:59:29 +0100 Subject: [PATCH] Bug 38201: Fix Dataproviders_spec.ts Signed-off-by: Jonathan Druart Signed-off-by: Lucas Gass --- .../integration/ERM/DataProviders_spec.ts | 8 ++++--- t/cypress/support/e2e.js | 24 +++++++++---------- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/t/cypress/integration/ERM/DataProviders_spec.ts b/t/cypress/integration/ERM/DataProviders_spec.ts index 72cc19d8285..528b6e61d0d 100644 --- a/t/cypress/integration/ERM/DataProviders_spec.ts +++ b/t/cypress/integration/ERM/DataProviders_spec.ts @@ -586,10 +586,11 @@ describe("Data provider tab options", () => { "X-Base-Total-Count": "0", "X-Total-Count": "0", }, - }); + }).as("no-titles"); // We'll test using titles but the component is the same for all four data types cy.get("#usage_data_providerstabs").contains("Titles").click(); + cy.wait("@no-titles"); cy.get("main div[class='alert alert-info']").should( "have.text", "No title data has been harvested for this provider" @@ -599,16 +600,17 @@ describe("Data provider tab options", () => { const title = cy.get_usage_title(); const titles = [title]; - cy.intercept("GET", "/api/v1/erm/usage_titles*", { + cy.intercept("GET", "/api/v1/erm/usage_titles?*", { statusCode: 200, body: titles, headers: { "X-Base-Total-Count": "1", "X-Total-Count": "1", }, - }); + }).as("provider-titles"); cy.get("#usage_data_providerstabs").contains("Titles").click(); + cy.wait(["@provider-titles", "@provider-titles"]); cy.get("#data_list").contains("Showing 1 to 1 of 1 entries"); }); diff --git a/t/cypress/support/e2e.js b/t/cypress/support/e2e.js index d2efe54732c..e0e8ca57673 100644 --- a/t/cypress/support/e2e.js +++ b/t/cypress/support/e2e.js @@ -1490,19 +1490,17 @@ cy.get_usage_data_provider = () => { }; cy.get_usage_title = () => { - return [ - { - online_issn: "2472-5390", - print_issn: "2472-5390", - publisher: "Wiley", - publisher_id: "0000000403801313", - title: "AEM Education and Training", - title_doi: "10.1002/(ISSN)2472-5390", - title_id: 1338, - title_uri: "", - usage_data_provider_id: 5, - }, - ]; + return { + online_issn: "2472-5390", + print_issn: "2472-5390", + publisher: "Wiley", + publisher_id: "0000000403801313", + title: "AEM Education and Training", + title_doi: "10.1002/(ISSN)2472-5390", + title_id: 1338, + title_uri: "", + usage_data_provider_id: 5, + }; }; cy.get_default_report = () => { -- 2.51.0