From 2c33001188097e81607d79fc99e49030185af66e Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 11 Sep 2025 09:57:51 +0200 Subject: [PATCH] Bug 39877: Do not clone if env var is not set MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If we don't want the incremental run we should return early in ->new to prevent the git clone. Signed-off-by: Tomás Cohen Arazi --- Koha/Devel/CI/IncrementalRuns.pm | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/Koha/Devel/CI/IncrementalRuns.pm b/Koha/Devel/CI/IncrementalRuns.pm index bb984a2bb86..4ffc39acd2c 100644 --- a/Koha/Devel/CI/IncrementalRuns.pm +++ b/Koha/Devel/CI/IncrementalRuns.pm @@ -83,21 +83,23 @@ sub new { context => $args->{context}, }; - unless ( $self->{test_name} ) { - my @caller_info = caller(); - my $script_filename = $caller_info[1]; - $self->{test_name} = basename($script_filename); - $self->{test_name} =~ s|/|_|g; - $self->{test_name} =~ s|\..*$||g; - } - - if ( $self->{git_repo_dir} && $self->{repo_url} ) { - unless ( -d $self->{git_repo_dir} ) { - qx{git clone $self->{repo_url} $self->{git_repo_dir}}; + if ( $self->{incremental_run} ) { + unless ( $self->{test_name} ) { + my @caller_info = caller(); + my $script_filename = $caller_info[1]; + $self->{test_name} = basename($script_filename); + $self->{test_name} =~ s|/|_|g; + $self->{test_name} =~ s|\..*$||g; } - qx{git -C $self->{git_repo_dir} fetch origin}; - make_path("$self->{git_repo_dir}/$self->{test_name}"); + if ( $self->{git_repo_dir} && $self->{repo_url} ) { + unless ( -d $self->{git_repo_dir} ) { + qx{git clone $self->{repo_url} $self->{git_repo_dir}}; + } + qx{git -C $self->{git_repo_dir} fetch origin}; + + make_path("$self->{git_repo_dir}/$self->{test_name}"); + } } bless $self, $class; -- 2.51.0