From af685c86e0a6a832f44e92b0eb23cf5741fbfb42 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Thu, 9 Oct 2025 12:58:36 +0000 Subject: [PATCH] Bug 39514: Only mark the affected rows as problematic Before this patch we were setting a variable and nebver unsetting it Now we can add the conditional directly to the row, so don't need a variable To test: 1. Go to Acquisitions 2. Click 'Search' in the vendor search 3. Click 'Add to basket' next to 'My basket' 4. Click 'From a new (empty) record' 5. Fill out the form - Title: enter a title - Koha item type: choose an item type 5.1. Click 'Add item' - Fund: choose a fund - Uncertain price: check 6. Click 'Save' 7. Go back to Acquisitions 8. Click 'Search' in the vendor search 9. Click 'New' > 'Basket' 10. Enter a basket name 11. Click 'Save' 12. Go back to Acquistions 13. Click 'Search' in the vendor search --> Notice the empty basket is also in bold red, even if it doesn't have uncertain prices 14. Click 'Add to basket' --> Notice everything is in bold and some in red 15. Apply patch, reload 16. Only affected basket is in red --- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt index 4e507b027ab..5b47155eab4 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt @@ -114,10 +114,7 @@ [% FOREACH basket IN supplier.loop_basket %] - [% IF ( basket.uncertainprices ) %] - [% SET tr_class="problem" %] - [% END %] - + [% basket.basketno | html %] [% basket.basketname | html %] -- 2.39.5