From 8608184b350635eeeae361eb742d3998383c6df7 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Wed, 8 Oct 2025 17:49:23 +0100 Subject: [PATCH] Bug 40866: Remove unused $message variable from circulation The $message variable was declared in circ/circulation.pl but never actually set, making the "No patron matched" template block unreachable. This is a remnant from old code that was incompletely cleaned when that functionality was changed/removed. This patch removes the unused variable, template parameter, and the unreachable template block. Signed-off-by: Martin Renvoize Signed-off-by: Andrew Fuerste Henry Signed-off-by: Paul Derscheid --- circ/circulation.pl | 3 --- koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 5 ----- 2 files changed, 8 deletions(-) diff --git a/circ/circulation.pl b/circ/circulation.pl index 01209d5eef0..13a4aff0b4e 100755 --- a/circ/circulation.pl +++ b/circ/circulation.pl @@ -326,8 +326,6 @@ if ($patron) { # STEP 3 : ISSUING # # -my $message; - if ( @$barcodes && $op eq 'cud-checkout' ) { my $checkout_infos; for my $barcode (@$barcodes) { @@ -784,7 +782,6 @@ $template->param( stickyduedate => $stickyduedate, duedatespec => $duedatespec, restoreduedatespec => $restoreduedatespec, - message => $message, totaldue => sprintf( '%.2f', $balance ), # FIXME not used in template? inprocess => $inprocess, $view => 1, diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt index 77007878821..92e438c86e2 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt @@ -787,11 +787,6 @@

Item checked out

[% END %] - [% IF ( message ) %] - [% INCLUDE 'patron-toolbar.inc' %] -

No patron matched [% message | html %]

- [% END %] - [% IF patron %] -- 2.39.5