From 52fed7f42ac21f3bc04e989dd4d8080f9847651e Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Fri, 21 Mar 2025 13:58:24 +0000 Subject: [PATCH] Bug 39408: Don't attempt to send a message if one is not generated The routine to create the message can return nothing if there is no content, we should handle this case and not attempt to send. To test: 1 - Test plan from last patch 2 - Apply this patch 3 - POST to patron API again 4 - Success! Signed-off-by: Claire Hernandez Signed-off-by: Martin Renvoize --- Koha/REST/V1/Patrons.pm | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/Koha/REST/V1/Patrons.pm b/Koha/REST/V1/Patrons.pm index b6d009c6437..7d733c10dc1 100644 --- a/Koha/REST/V1/Patrons.pm +++ b/Koha/REST/V1/Patrons.pm @@ -121,9 +121,8 @@ sub add { module => 'members', letter_code => 'WELCOME', branchcode => $patron->branchcode, - , - lang => $patron->lang || 'default', - tables => { + lang => $patron->lang || 'default', + tables => { 'branches' => $patron->branchcode, 'borrowers' => $patron->borrowernumber, }, @@ -139,7 +138,9 @@ sub add { message_transport_type => 'email' } ); - SendQueuedMessages( { message_id => $message_id } ); + + # Don't send a message if we didn't generate one for some reason + SendQueuedMessages( { message_id => $message_id } ) if $message_id; } } } -- 2.51.0