From 8a7e198ced9601c6b878986b7d5179ec7b0cbf34 Mon Sep 17 00:00:00 2001 From: Pedro Amorim Date: Tue, 30 Sep 2025 14:21:15 +0000 Subject: [PATCH] Bug 41001: Remove messages when dialog closes, even if not through the close button This ensures that when the dialog is closed, even when clicked outside of it, the messages are correctly removed, same as if the 'close' button had been clicked. Test plan: - create a data ERM provider /cgi-bin/koha/erm/eusage/usage_data_providers/add - dummy data should be sufficient - then go to data providers list /cgi-bin/koha/erm/eusage/usage_data_provider - open web development tools console (F12 firefox) - click on "Run now" - dismiss dialog by clicking outside the modal! - click again on "Run now" - check the logs for errors - any other clicks to create a modal won't work now ("run now", "delete") Apply patch. run yarn js:watch or yarn js:build. Repeat. --- koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue index 4e48f53d311..162c93a7da7 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue @@ -172,6 +172,9 @@ export default { return; } nextTick(() => { + $("#warning.modal").on("hidden.bs.modal", function () { + removeMessages(); + }); $("#warning.modal").modal("show"); }); }); @@ -182,6 +185,9 @@ export default { return; } nextTick(() => { + $("#confirmation.modal").on("hidden.bs.modal", function () { + removeConfirmationMessages(); + }); $("#confirmation.modal").modal("show"); }); }); -- 2.39.5