From bc42621cdccf30acf75f9efd5c34e407fa10c094 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Wed, 22 Oct 2025 18:00:33 +0000 Subject: [PATCH] Bug 41074: Don't reverse previous_patrons arrary This patch alters the code to append instead of prepend, removing the need to reverse the list To test: 1 - Write a report to get some patron SELECT cardnumber,surname FROM borrowers WHERE cardnumber <>'' ORDER BY rand() LIMit 6 2 - Enabled 'showLastPatron' and set count to 3 http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=showLastPatron 3 - Copy the barcodes in order from the report and search for them in patron search, you'll want two tabs so you can keep report open 4 - Notice at 4th patron that list order has changed 5 - When 5th patron is loaded, the 4th is removed from the list 6 - Apply patch 7 - Clear the list 8 - Repeat the test plan, but note that list order does not change 9 - Confirm the patrons are removed from the list in expected order when adding new 10 - Change the count to 1 and search for several patrons, ensuring the last patron link is always correct --- koha-tmpl/intranet-tmpl/prog/js/staff-global.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js index ed6f0b35f7b..29a1f3b0643 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js +++ b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js @@ -256,11 +256,10 @@ $(document).ready(function () { ); $("#lastborrower-window").css("display", "inline-flex"); - previous_patrons.reverse(); for (i in previous_patrons) { p = previous_patrons[i]; const el = `
  • ${p["name"]} (${p["card"]})
  • `; - $("#lastBorrowerList").prepend(el); + $("#lastBorrowerList").append(el); } } -- 2.39.5