From 603bcbe3654cea25ddee97f2af27df1b1cef8db1 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 23 Oct 2025 09:45:11 +0200 Subject: [PATCH] Bug 41079: Turn on bKohaColumnsUseNames for the batch patron modification results table A table cannot use the table settings if columns are displayed depending on sysprefs. Additionally DT's saveState does not work correctly if some columns are shown/hidden from one screen to another. We must add data-colname and turn bKohaColumnsUseNames on for this table. Also note that there were several discrepancies between the table structure and the number of columns in the yaml file. Signed-off-by: Nick Clemens --- admin/columns_settings.yml | 8 +++ .../prog/en/modules/tools/modborrowers.tt | 65 +++++++++---------- 2 files changed, 39 insertions(+), 34 deletions(-) diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml index 58a7493212d..7bb64e61589 100644 --- a/admin/columns_settings.yml +++ b/admin/columns_settings.yml @@ -2519,14 +2519,22 @@ modules: columnname: batch_patron_edit_phone - columnname: batch_patron_edit_mobile + - + columnname: batch_patron_edit_fax - columnname: batch_patron_edit_dateenrolled - columnname: batch_patron_edit_dateexpiry + - + columnname: batch_patron_edit_password_expiration_date + - + columnname: batch_patron_edit_protected - columnname: batch_patron_edit_borrowernotes - columnname: batch_patron_edit_opacnote + - + columnname: batch_patron_edit_messages - columnname: batch_patron_edit_debarred - diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt index 8ce6ff1cfa3..64ae308ec05 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt @@ -217,40 +217,32 @@ - [% IF ( op == 'show' ) %] - - [% ELSE %] - - [% END %] - - - - - - - - - - - - - - - - - - - [% IF CanUpdatePasswordExpiration %] - - [% END %] - [% IF CanUpdateProtectPatron %] - - [% END %] - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + [% FOREACH attrh IN attributes_header %] [% END %] @@ -286,6 +278,8 @@ [% ELSE %] [% END %] + [% ELSE %] + [% END %] [% IF CanUpdateProtectPatron %] + [% ELSE %] + [% END %] @@ -504,6 +500,7 @@ { order: [[1, "asc"]], autoWidth: true, + bKohaColumnsUseNames: true, }, table_settings ); -- 2.39.5
  Card numberSurnameFirst nameLibraryPatron categoryStreet numberAddressAddress 2CityStateZIP/Postal codeCountryPrimary emailPrimary phoneOther phoneFaxRegistration dateExpiry datePassword expiration dateProtectedCirculation noteOPAC noteMessageRestriction expirationRestriction comment Card numberSurnameFirst nameLibraryPatron categoryStreet numberAddressAddress 2CityStateZIP/Postal codeCountryPrimary emailPrimary phoneOther phoneFaxRegistration dateExpiry datePassword expiration dateProtectedCirculation noteOPAC noteMessageRestriction expirationRestriction comment[% attrh.attribute | html %]Never @@ -295,6 +289,8 @@ No [% END %] [% borrower.borrowernotes | $raw | html_line_break %] [% borrower.opacnote | html %]