From bb952265e0808b04b5a6b0ad456880e9c1c011b2 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 23 Oct 2025 10:00:35 +0200 Subject: [PATCH] Bug 41079: Force visibility for columns depending on sysprefs If two sysprefs are disabled we must hide the two related columns. We should also force the visibility of the checkboxes: on the first screen (op=show/edition) they must be displayed, on the result screen (op=show_results) the must be hidden. Test plan: 1. Create a report to see some patrons: SELECT cardnumber FROM borrowers WHERE cardnumber LIKE '%2' 2. Run report and select 'Batch operations ...' 3. Batch patron modification => Notice that the table has the checkboxes in the first column => The table is sorted by cardnumber 4. Perform the modification => Notice that the result table does not have the checkboxes in the first column => The table is still sorted by cardnumber Additional tests: 1. If the logged in user is superlibrarian then the columns "Password expiration date" and "Protected" are displayed 2. Play with the table's settings and columns visibility to confirm that they are working correctly (they were not before this patch set) Signed-off-by: Nick Clemens --- .../prog/en/modules/tools/modborrowers.tt | 51 +++++++++++++++---- 1 file changed, 40 insertions(+), 11 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt index 64ae308ec05..8a96bdb1c3d 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt @@ -251,7 +251,7 @@ [% FOREACH borrower IN borrowers %] - + [% borrower.cardnumber | html %] @@ -484,18 +484,47 @@